Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyError: 'drill size required (like "drill=1")' #80

Open
dzid26 opened this issue Jan 1, 2025 · 0 comments
Open

KeyError: 'drill size required (like "drill=1")' #80

dzid26 opened this issue Jan 1, 2025 · 0 comments

Comments

@dzid26
Copy link

dzid26 commented Jan 1, 2025

Describe the bug
Importing C67381, C309352

JLC2KiCadLib C67381
2025-01-01 22:00:09,644 - INFO - creating library for component C67381
2025-01-01 22:00:10,150 - INFO - creating footprint ...
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "C:\Program Files\Python311\Scripts\JLC2KiCadLib.exe\__main__.py", line 7, in <module>
  File "C:\Program Files\Python311\Lib\site-packages\JLC2KiCadLib\JLC2KiCadLib.py", line 181, in main
    add_component(component, args)
  File "C:\Program Files\Python311\Lib\site-packages\JLC2KiCadLib\JLC2KiCadLib.py", line 30, in add_component
    footprint_name, datasheet_link = create_footprint(
                                     ^^^^^^^^^^^^^^^^^
  File "C:\Program Files\Python311\Lib\site-packages\JLC2KiCadLib\footprint\footprint.py", line 87, in create_footprint
    handlers.get(model)(args[1:], kicad_mod, footprint_info)
  File "C:\Program Files\Python311\Lib\site-packages\JLC2KiCadLib\footprint\footprint_handlers.py", line 184, in h_PAD
    Pad(
  File "C:\Program Files\Python311\Lib\site-packages\KicadModTree\nodes\base\Pad.py", line 232, in __init__
    self._initDrill(**kwargs)  # requires pad type and offset
    ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Program Files\Python311\Lib\site-packages\KicadModTree\nodes\base\Pad.py", line 307, in _initDrill
    raise KeyError('drill size required (like "drill=1")')
KeyError: 'drill size required (like "drill=1")'

To Reproduce
Steps to reproduce the behavior:

  1. JLC2KiCadLib C67381

Additional context
This error was not appearing with 1.0.28 d651d3f

But even at 1.0.28, there is still an issue that pads on bottom layer don't get imported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant