Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse 'Look' Description Grammar #35

Open
egocarib opened this issue Feb 10, 2021 · 0 comments
Open

Parse 'Look' Description Grammar #35

egocarib opened this issue Feb 10, 2021 · 0 comments
Assignees

Comments

@egocarib
Copy link
Member

As I was working on ?wikipage embeds for cryptogull, I ended up having to make an extra API call to the expandtemplates API to remotely call Template:Grammar in order to parse look descriptions correctly to be displayed on Discord.

It would be nice if we can parse those descriptions in hagadias before uploading to the wiki instead. This would improve performance of the ?wikipage embed by removing the need for the extra API call.

If we do address this issue at some point, we should completely remove the _parse_grammar method from cryptogull's wiki_page.py module, and we can also remove the single call to that method (self._look_description = await self._parse_grammar(self._look_description, wiki_text))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants