Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor shortcuts collision on firefox #21019

Open
1 task done
johnHackworth opened this issue Sep 17, 2024 · 4 comments
Open
1 task done

editor shortcuts collision on firefox #21019

johnHackworth opened this issue Sep 17, 2024 · 4 comments
Labels
P4 - Low stale [triage] Issues that were closed to to lack of traction

Comments

@johnHackworth
Copy link

johnHackworth commented Sep 17, 2024

Issue Summary

The shortcut to convert the selected text to a quote (ctrl+Q) doesn't work on firefox (130.0) because it's already used by the browser (to close all the windows) and can't be overtaken by a site.

Steps to Reproduce

  1. Edit a post with Firefox 130.0
  2. Write a text & select it
  3. Press Ctrl+Q

Ghost Version

5.94.1

Node.js Version

18.20.0

How did you install Ghost?

using ghost-cli

Database type

MySQL 5.7

Browser & OS version

Firefox 130.0 on Ubuntu 22.04.4

Relevant log / error output

imagen

Code of Conduct

  • I agree to be friendly and polite to people in this repository
@github-actions github-actions bot added the needs:triage [triage] this needs to be triaged by the Ghost team label Sep 17, 2024
Copy link
Contributor

sagzy commented Sep 17, 2024

Hey johnHackworth, thanks for raising the issue 🙏

@sagzy sagzy added the P4 - Low label Sep 17, 2024 — with Linear
@sagzy sagzy removed the P4 - Low label Sep 17, 2024
@sagzy sagzy added the P4 - Low label Sep 17, 2024 — with Linear
@sagzy sagzy removed the needs:triage [triage] this needs to be triaged by the Ghost team label Sep 17, 2024
@suryatejess
Copy link

I suggest redefining the shortcut to Ctrl+Shift+Q to avoid conflicts with the existing Firefox shortcut (Ctrl+Q). I’d like to work on this issue and implement the change.

Thank you!

@markstos
Copy link
Contributor

Ctrl+Shift+Q seems like a logical alternative. There are other shortcuts that use the Control+Shift prefix.

Copy link
Contributor

Our bot has automatically marked this issue as stale because there has not been any activity here in some time.

The issue will be closed soon if there are no further updates, however we ask that you do not post comments to keep the issue open if you are not actively working on a PR.

We keep the issue list minimal so we can keep focus on the most pressing issues. Closed issues can always be reopened if a new contributor is found. Thank you for understanding 🙂

@github-actions github-actions bot added the stale [triage] Issues that were closed to to lack of traction label Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P4 - Low stale [triage] Issues that were closed to to lack of traction
Projects
None yet
Development

No branches or pull requests

4 participants