From 8f7b7d3b9d605f342a73aa8deed10f3caa237e59 Mon Sep 17 00:00:00 2001 From: LuckyNoS7evin <30657709+LuckyNoS7evin@users.noreply.github.com> Date: Thu, 15 Mar 2018 21:21:03 +0000 Subject: [PATCH 1/2] Major Issue - Secret Check (#4) Rotated Secret Manager would never have worked only checks current secret not older ones which may still be valid. --- TwitchLib.Extension/Extension/ExtensionBase.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/TwitchLib.Extension/Extension/ExtensionBase.cs b/TwitchLib.Extension/Extension/ExtensionBase.cs index 505c09f..1182021 100644 --- a/TwitchLib.Extension/Extension/ExtensionBase.cs +++ b/TwitchLib.Extension/Extension/ExtensionBase.cs @@ -335,7 +335,7 @@ private ClaimsPrincipal VerifyWithSecret(string jwt, string secret, out Security { var validationParameters = new TokenValidationParameters { - IssuerSigningKey = new SymmetricSecurityKey(Convert.FromBase64String(CurrentSecret)), + IssuerSigningKey = new SymmetricSecurityKey(Convert.FromBase64String(secret)), ValidateAudience = false, ValidateLifetime = false, ValidateIssuer = false, From b95785ea58b8bef0639a81a020ff0d156de1db49 Mon Sep 17 00:00:00 2001 From: LuckyNoS7evin <30657709+LuckyNoS7evin@users.noreply.github.com> Date: Mon, 19 Mar 2018 00:08:58 +0000 Subject: [PATCH 2/2] Update Travis (#6) * Update Travis * travis update 2 --- .travis.yml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 .travis.yml diff --git a/.travis.yml b/.travis.yml new file mode 100644 index 0000000..f2d1942 --- /dev/null +++ b/.travis.yml @@ -0,0 +1,17 @@ +language: csharp +mono: none +dotnet: 2.0.0 +dist: trusty +script: + - dotnet restore + - dotnet build /home/travis/build/TwitchLib/TwitchLib.Extension/TwitchLib.Extension/TwitchLib.Extension.csproj --framework netstandard2.0 + - dotnet build /home/travis/build/TwitchLib/TwitchLib.Extension/TwitchLib.Extension.Core/TwitchLib.Extension.Core.csproj + +addons: + apt: + sources: + - sourceline: 'deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-trusty-prod trusty main' + key_url: 'https://packages.microsoft.com/keys/microsoft.asc' + packages: + - dotnet-hostfxr-1.0.1 + - dotnet-sharedframework-microsoft.netcore.app-1.0.5 \ No newline at end of file