Problem with the latest wrapper beta

[cdietrich]

hi,

after updating to next.7 and vscode-api 11.1.1

am getting this from the bundler

> @everestsystems/[email protected] build
> tsc --noEmit -p ./tsconfig.json && node build.mjs

✘ [ERROR] Could not resolve "@codingame/monaco-vscode-chat-extensions-notebook-task-terminal-testing-common/vscode/vs/workbench/contrib/terminal/common/terminal"

    ../../node_modules/vscode/vscode/src/vs/workbench/contrib/terminal/common/terminalContextKey.js:3:33:
      3 │ import { TERMINAL_VIEW_ID } from '@codingame/monaco-vscode-chat-extensions-notebook-task-terminal-testing-common/vscode/vs/workbench/contrib/terminal/common/termin...
        ╵                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

in my transitives (yarn.lock" i can see @codingame/monaco-vscode-chat-extensions-notebook-common only

[cdietrich]

[cdietrich]

maybe this is not a dev dependency after all

[kaisalmen]

@cdietrich you are talking about -next.8, right? The root cause needs to be fixed by @CGNonofr . WA: is to add it as dependency.
Verification examples are broken as well. Our production build works, though. I need to release a -next.9

[cdietrich]

afff yes

"monaco-editor-wrapper": "6.0.0-next.8",
"monaco-languageclient": "9.0.0-next.8",

[kaisalmen]

Verification builds are running, but I did not need to add the above dependency. Let's see what happens in the pipeline:
https://github.com/TypeFox/monaco-languageclient/actions/runs/11972730661/job/33380237247

[kaisalmen]

Oh boy, my computer has Friday. 🙈 I don't see the errors locally. ⬆️

[kaisalmen]

Will add dependency there first and if that works, add it to the wrapper as WA and release new versions.

[kaisalmen]

Reminder to myself: Always remove package-lock file and node_modules if you want to start fresh (npm run reset:repo exists for a reason)

[kaisalmen]

@cdietrich -next.9 versions are available. Verification build is still running, but looking good, so far:
https://github.com/TypeFox/monaco-languageclient/actions/runs/11973325975/job/33382171130

[kaisalmen]

@cdietrich workaround is in place and works (verification is ✅ again). We will keep this issue open until the root cause is fixed.

[jhk-mjolner]

I'm experiencing this problem now, while updating my frontend packages.

I've updated to monaco-languageclient version 9.0.0 and various @codingame/ extensions to version 11.1.2 following the compatibility table at https://github.com/TypeFox/monaco-languageclient/blob/main/docs/versions-and-history.md#monaco-editor--codingamemonaco-vscode-api-compatibility-table
The extensions are

@codingame/monaco-vscode-json-default-extension
@codingame/monaco-vscode-languages-service-override
@codingame/monaco-vscode-model-service-override
@codingame/monaco-vscode-textmate-service-override
@codingame/monaco-vscode-theme-defaults-default-extension
@codingame/monaco-vscode-theme-service-override

monaco-editor-workers is at 0.45.0, and vscode-ws-jsonrpc is at 3.4.0 if that has any relevance.
I'm NOT using the wrapper, as I'm updating from a setup from before the wrapper, and adapting to the wrapper would be more work.

The workaround of installing @codingame/monaco-vscode-chat-extensions-notebook-task-terminal-testing-common myself seems to work. But I'm noticing that no one is assigned to this issue, and I wonder if anybody is working towards fixing the root cause?

[kaisalmen]

Hi @jhk-mjolner thank you, that is a good point. @CGNonofr have you already tracked the issue on the monaco-vscode-api side?

[CGNonofr]

Hi @jhk-mjolner thank you, that is a good point. @CGNonofr have you already tracked the issue on the monaco-vscode-api side?

I'm aware of that issue and I've already work on a solution for a few weeks now, but it's not ready yet

[kaisalmen]

I'm aware of that issue and I've already work on a solution for a few weeks now, but it's not ready yet

👍 I guessed that it is part of the bigger build rework

[kaisalmen]

monaco-vscode-api v12 will be integrated soon.