Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📊 Improving Analysis Code #46

Open
dpshelio opened this issue Dec 7, 2023 · 2 comments
Open

📊 Improving Analysis Code #46

dpshelio opened this issue Dec 7, 2023 · 2 comments
Labels
week09 Structure and design

Comments

@dpshelio
Copy link
Contributor

dpshelio commented Dec 7, 2023

Open the repository for this exercise. You will find a brief description of each example in its README.md file.

  1. Discuss the code with your group. What problems do you see with it? Why?
  2. Write below your comments mentioning your group number. For now, focus on the
    problems, and don't make any changes yet!
@dpshelio dpshelio added the week09 Structure and design label Dec 7, 2023
@slmo85
Copy link

slmo85 commented Dec 7, 2023

Group 9
the code is repetitive (open data1, open data2), the variable names are ambiguous/unhelpful, there's a section of code commented out in workflow2 that doesnt have any comments explaining why, if it will be used again, if it works/doesnt.
they also import everything from math and then dont use it

@SarahLittlejohn
Copy link

SarahLittlejohn commented Dec 7, 2023

Group 8

  • Variable names especially the 1 character ones.
  • Repetition in code - e.g. the read in function for files shouldn't be repeated (could e make into one function).
  • The two files are really similar - instead of commenting out the part of the code that is different you could use an if statement instead.
  • File names also not great.
  • Not enough comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
week09 Structure and design
Projects
None yet
Development

No branches or pull requests

3 participants