Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TADA.ResultValueBelowLowerThreshold.Flag includes 0 #265

Closed
ehinman opened this issue May 10, 2023 · 1 comment · Fixed by #540
Closed

TADA.ResultValueBelowLowerThreshold.Flag includes 0 #265

ehinman opened this issue May 10, 2023 · 1 comment · Fixed by #540
Labels
bug Good First Issue Good issue for first time contributors hacktoberfest Module 1 MVP Top Priority

Comments

@ehinman
Copy link
Contributor

ehinman commented May 10, 2023 •
edited by cristinamullin
Loading

Describe the bug
Sometimes, the WQX threshold is greater than 0, which means any results reported as 0 are flagged for removal. Is this the desired behavior?

Expected behavior
It might be nice to be able to separate WQX thresholds from non-sensical values? I think we're using the thresholds to get at values that might be non-sensical, but it's not always a 1:1 match between the two types of tests.
@cristinamullin cristinamullin added Good First Issue Good issue for first time contributors hacktoberfest labels Oct 2, 2023
@cristinamullin
Copy link
Collaborator

cristinamullin commented Oct 2, 2023 •
edited
Loading

Suggest to update both TADA functions that use the WQX thresholds to use the logic: greater than or equal to 0

@cristinamullin cristinamullin mentioned this issue Nov 22, 2023
Open
@cristinamullin cristinamullin self-assigned this Feb 12, 2024
@cristinamullin cristinamullin removed their assignment May 1, 2024
@cristinamullin cristinamullin self-assigned this May 1, 2024
@cristinamullin cristinamullin removed their assignment Oct 24, 2024
@hillarymarler hillarymarler linked a pull request Nov 7, 2024 that will close this issue
397 range check bug #540
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Good First Issue Good issue for first time contributors hacktoberfest Module 1 MVP Top Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

397 range check bug USEPA/EPATADA
3 participants
@cristinamullin @ehinman @hillarymarler