Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect hotelling emissions in MOVES4 when providing HotellingHoursPerDay input and not all months are selected #83

Open
danielbizercox opened this issue Jan 13, 2025 · 0 comments
Open

Incorrect hotelling emissions in MOVES4 when providing HotellingHoursPerDay input and not all months are selected #83

danielbizercox opened this issue Jan 13, 2025 · 0 comments
Labels
bug Something isn't working
Milestone
MOVES4.0.2

Comments

@danielbizercox
Copy link
Collaborator

MOVES4 uses incorrect hotelling activity if you supply a custom HotellingHoursPerDay input, but do not select all months in the RunSpec. In this case, the total number of hotelling hours in the output is too high by the ratio of 12 / (number of months in RunSpec).

We plan to fix this in an upcoming patch to MOVES4.

Note: this issue does not impact MOVES5.
@danielbizercox danielbizercox added the bug Something isn't working label Jan 13, 2025
@danielbizercox danielbizercox added this to the MOVES4.0.2 milestone Jan 13, 2025
danielbizercox added a commit that referenced this issue Jan 14, 2025
@danielbizercox
When adjusting hotellinghours to match user input hotellingHoursPerDa…
9be3f07 
…y, account for the number of months in the runspec (#83)

The previous code assumed 12 months in the runspec, which results in 12x too many hotelling hours if there's only one month in the runspec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
MOVES4.0.2
Development

No branches or pull requests
1 participant
@danielbizercox