New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeReview TODOs: task_abandoned_coal_emis.py #35

Open

Jbollenbacher opened this issue Jan 13, 2025 · 0 comments

Assignees

Collaborator

Jbollenbacher commented Jan 13, 2025 •

edited

Loading

Code review of file task_abandoned_coal_emis.py

Good:

Input and output data files are present at specified filepaths
Units and formatting of output data is compliant
Header comment has been made compliant
Comments explain data operations

Bad:

Code uses gch4i_data_guide_v3.xlsx to specify input and output file params; this harms legibility.
Comments on loading the data via gch4i_data_guide_v3.xlsx are somewhat lacking
Filepaths, sheetnames, etc are outdated

TODO:

@nkruskamp See TODO comments here in the code review branch. Notably: Update the sheet_name and source_name used for reading params out of gch4i_data_guide_v3.xlsx

Jbollenbacher assigned nkruskamp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment