Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Dependencies of given Depin to Decorators #65

Open
Voiteh opened this issue Mar 7, 2020 · 1 comment
Open

Expose Dependencies of given Depin to Decorators #65

Voiteh opened this issue Mar 7, 2020 · 1 comment
Assignees
@Voiteh
Labels
API Change Change to the API Breaking change Enhancement New feature or request Priority Low Low priority issue Question Further information is requested

Comments

@Voiteh
Copy link
Owner

Voiteh commented Mar 7, 2020

While implementing subtype annotation of Collector I noticed that this can be done in manner of Dependnency.Decorator or as standalone OptionalAnnotation, which would be checked from within of CollectorDependancy . The things which need to be taken in consideration are:

  • Type compatibility - the implementator of Dependency.Decorator, would be able to retreive other dependencies this could introduce issues from users, which would be addressed to me instead of implementator of Dependency.Decorator. Right now this is not the case.
  • Accesibility to Dependencies object methods would require to be reduced via some interface.
  • BC break, definition of Dependency.Decorator would change .
@Voiteh Voiteh added Enhancement New feature or request Question Further information is requested Priority Low Low priority issue API Change Change to the API Breaking change labels Mar 7, 2020
@Voiteh Voiteh self-assigned this Mar 7, 2020
@Voiteh Voiteh closed this as completed Apr 4, 2020
@Voiteh Voiteh added the Invalid This doesn't seem right label Apr 4, 2020
@Voiteh Voiteh removed the Invalid This doesn't seem right label Apr 4, 2020
@Voiteh
Copy link
Owner Author

Voiteh commented Apr 4, 2020

I don't want to expose to much info through decorators. For now it is on hold

@Voiteh Voiteh reopened this Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Voiteh Voiteh

Labels
API Change Change to the API Breaking change Enhancement New feature or request Priority Low Low priority issue Question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Voiteh