Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

More cleanup/typos in TCK #21

Open
scottkurz opened this issue Oct 9, 2015 · 0 comments
Open

More cleanup/typos in TCK #21

scottkurz opened this issue Oct 9, 2015 · 0 comments

Comments

@scottkurz
Copy link
Member

  1. StartLimitTests
  • Fix comment: Tests that allow-start-if-complete "trumps" start-limit in the sense
  1. DoSomethingArrayItemReaderImpl has a confused checkpoint strategy in the boundary case of ‘zero’… with an item-count of 1. It works though
  2. timestamps mixed in metricstests (from junit and from jobexecution) - inconsistent print formatting
  3. unused 2nd step: should be called out in some form: ExecutionTests#testInvokeJobWithNextElement
  4. For ParallelExecTests# testPartitionedMapperOverrideFalseOnRestart, we’re using a different # of partitions on restart with override = false. So in expecting the job to complete with a successful exit status, we’re requiring an impl doesn’t flat out mark this invalid and fail to allow restart altogether.
  • Test comment is weak
  • Let’s also check for completed batch status since that’s another part of what we’re trying to test).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant