Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: filename doesn't correctly reflect the selected location when downloading chart png or csv #1413

Open
wadhwamatic opened this issue Jan 15, 2025 · 1 comment
Assignees
Labels
bug Something isn't working triage to be triaged for next action

Comments

@wadhwamatic
Copy link
Member

wadhwamatic commented Jan 15, 2025

What happened?

When I compare two locations in the charts module and then download a csv or png, the location name in the filename doesn't always correspond with the location I've selected.

Steps to reproduce:

  1. Go to the charts module
  2. Toggle on compare locations
  3. Choose any two locations
  4. Click download CSV or PNG in the top right of the chart in location 1, and again for location 2
  5. See that the same location name in the filename is applied to both files

Which country / deployment are you running?

all countries / main

Add a screenshot (if relevant)

In this example, the filename of the png for both charts is mozambique_gaza_blended_rainfall_aggregate_10_day. The right side chart should be mozambique_tete_blended_rainfall_aggregate_10_day

Screenshot 2025-01-15 at 11 02 46
@wadhwamatic wadhwamatic added bug Something isn't working triage to be triaged for next action labels Jan 15, 2025
@wadhwamatic wadhwamatic self-assigned this Jan 15, 2025
@ericboucher
Copy link
Collaborator

Nice catch!

This should be updated to display the comparison info:

showDownloadIcons: true,
downloadFilenamePrefix: singleDownloadChartPrefix,
}}
/>

                chartProps={{
                  showDownloadIcons: true,
                  downloadFilenamePrefix: singleDownloadChartPrefix,
                }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage to be triaged for next action
Projects
None yet
Development

No branches or pull requests

2 participants