Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some way to change the previewed piece in Lishogi's piece set menu. #859

Open
Eventlesstew opened this issue Sep 10, 2024 · 3 comments

Comments

@Eventlesstew
Copy link

Not sure myself how a UI for this would be made, but being able to change the previewed piece from a Gold General in the Piece set menu to another piece would help players find their preferred set better without going through everything to find the one they want.

Not all pieces have to be in there, a handful such as a Gold for obvious reasons, A Silver to distinguish coloured piece sets, a Dragon Horse to distinguish red and black promoted pieces, are enough.

@ddugovic
Copy link

Hovering could perhaps show more pieces.
image

@Eventlesstew
Copy link
Author

Oh yeah, we could have a sidebar that shows the pieces in the style we're hovering over.

@WandererXII
Copy link
Owner

Or maybe on hover change the displayed piece each second as long the user is hovering, or an option to pick what piece is displayed for all the piece sets, but some tooltip would be best probably. But since this isn't something that users do often, maybe it's fine the way it is.
Sidenote, probably better to have one css file with all the pieces as data-uri, instead of 20 or something separate requests, this file might be kinda big tho, if we decide to have several pieces displayed for each set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants