Unreadable colors

[aleksator]

I have a problem with default coloring scheme. It contains both white and dark gray colored words, so half of it is very hard to read with whitish background theme, while another half with dark background theme (see screenshot).

Hors version is 0.6.4, run under KDE, Yakuake, Sweet console theme.
I tried other themes and it was still problematic.

[dzervas]

This will be solved with #61 I think, where the color scheme will be configurable.

Apart from that though, I think that you've changed the default colors (terminal themes tend to do that), so for example red could appear as blue. To fix that, I think the best solution is to use more "safe" colors as default, so that it appears "good enough" on most terminal themes. We can read how highlight or https://github.com/sharkdp/bat do things and how they picked colors.

[aleksator]

I don't think the issue is the current theme that I am using, as I noted I tried different ones.
Here's the example with default KDE terminal theme Breeze (I changed global KDE theme to default Breeze Dark as well just in case):

With terminal theme set to "White on Black":

In fact, hors output colors don't change with the theme at all as far as I noticed, only the colors of the text I typed and the background change.

[dzervas]

Oh, I hear you...

[WindSoilder]

Hi, thanks for your report, I can reproduce this issue too.

It seems that hors does not take the most approprate tag to colorize output. For this link, it just take json scheme to colorize....

Maybe I need to take a little time to think how to fix it appropriately.

[WindSoilder]

Oh, maybe there is a better way to select language scheme to colorize code.

I can make use of this attribute :-)

[dzervas]

oh ok, if it's a problem on that specific answer (marked as java while it's Rust) I don't consider it a bug

[WindSoilder]

@aleksator Hi, I have publish a new version(0.6.6) to handle this, feel free to check it out :-)

[aleksator]

@WindSoilder Looks great! Thank you.