Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGRS conversion fixes #67

Closed
wcmatthysen opened this issue Aug 7, 2019 · 4 comments
Closed

MGRS conversion fixes #67

wcmatthysen opened this issue Aug 7, 2019 · 4 comments
Labels
bug Something isn't working
Milestone
WWJ-CE 2.2.0

Comments

@wcmatthysen
Copy link
Member

Pull in fixes for MGRS coordinate conversion from upstream PR #157 of @gbburkhardt. The corresponding description from the PR is:

Fix two problems:

a) Index out of bounds error due to typo in convertMGRSToUPS; clearly the index should have been 1 instead of 12.
b) Conversions from geodetic to MGRS would fail for low southern latitudes (zone 0). Geotrans 3.7 has this problem fixed. The WorldWind conversion code was derived from NGA's Geotrans. Test case:
Lat: -89.345400 deg, Lon: -48.930600 deg ==> MGRS: AZN 45208 47747

See issue #160 in upstream repository as well.
@wcmatthysen wcmatthysen added the bug Something isn't working label Aug 7, 2019
@wcmatthysen wcmatthysen added this to the WWJ-CE 2.2.0 milestone Aug 7, 2019
@ComBatVision
Copy link
Member

ComBatVision commented Aug 7, 2019 •
edited
Loading

By the way, I have ported this conversions earlier to Android code base.
So I probably need to copy this fixes to Android branch too.
Will wait the result.

WorldWindEarth/WorldWindAndroid#16

@wcmatthysen wcmatthysen mentioned this issue Aug 7, 2019
Closed
@gbburkhardt gbburkhardt mentioned this issue Aug 14, 2019
Merged
@wcmatthysen
Copy link
Member Author

OK, the fix for this was done in PR #72. I'll take a look at porting the fixes to the Android code-base before closing this issue.

@PJHogan
Copy link
Member

PJHogan commented Aug 14, 2019

You guys are AMAZING! Nice work!

@wcmatthysen
Copy link
Member Author

The fixes are now ported to the Android code-base. So, I guess we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
WWJ-CE 2.2.0
Development

No branches or pull requests
3 participants
@wcmatthysen @ComBatVision @PJHogan