Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add numpy to requirements #44

Open
deanmalmgren opened this issue May 11, 2018 · 3 comments
Open

add numpy to requirements #44

deanmalmgren opened this issue May 11, 2018 · 3 comments

Comments

@deanmalmgren
Copy link

In trying to run the ./examples/cube.py, I got an error about trying to import numpy:

Traceback (most recent call last):
  File "legos.py", line 4, in <module>
    import vapory
  File "/Users/rdm/.virtualenvs/lego-construction/lib/python3.6/site-packages/vapory/__init__.py", line 4, in <module>
    from .vapory import *
  File "/Users/rdm/.virtualenvs/lego-construction/lib/python3.6/site-packages/vapory/vapory.py", line 4, in <module>
    from .io import render_povstring
  File "/Users/rdm/.virtualenvs/lego-construction/lib/python3.6/site-packages/vapory/io.py", line 11, in <module>
    import numpy
ModuleNotFoundError: No module named 'numpy'

I'm not entirely sure numpy is needed, but if it is, it should be listed in the setup.py.

@maryito
Copy link

maryito commented Aug 23, 2018

Hi managed to solve by installing numpy through pip
pip install numpy

@NGeorgescu
Copy link
Contributor

NGeorgescu commented Jul 8, 2019

Ah looks like the code has an except for an IOError but not for a ModuleNotFoundError. That should be fixed. Probably not a lot of people run into this problem since numpy is a very commonly used module.

@NGeorgescu
Copy link
Contributor

This issue has been fixed. If you import the library without numpy it works but if you need numpy for the particular function only then will it stop you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants