Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DUNE_BUILD_DIR to search for files #442

Open
maxim092001 opened this issue Jul 26, 2024 · 1 comment
Open

Use DUNE_BUILD_DIR to search for files #442

maxim092001 opened this issue Jul 26, 2024 · 1 comment

Comments

@maxim092001
Copy link
Contributor

Hi.

In input.ml we use _build as a hardcoded value for search. However, some users may override DUNE_BUILD_DIR or pass it as a flag to dune as per dune docs.

This issue is a request to use DUNE_BUILD_DIR instead of _build. Note, that DUNE_BUILD_DIR=_build by default.

Let me know if this change would make sense and you'd be happy for us to contribute it!

Best,
Max.

@aantron
Copy link
Owner

aantron commented Jul 26, 2024

Hi! I think that makes sense. I would merge such a change. It looks like DUNE_BUILD_DIR has been around since Dune 1.0.0. However, we should probably fall back to searching in a potential _build directory, as now, if the environment variable is undefined for some reason.

If a user passes in --build-dir foo, is DUNE_BUILD_DIR set to foo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants