Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CryptoPP 8.9.0 fails to link when using MSYS2 Clang #103

Closed
ghost opened this issue Oct 5, 2023 · 3 comments
Closed

CryptoPP 8.9.0 fails to link when using MSYS2 Clang #103

ghost opened this issue Oct 5, 2023 · 3 comments

Comments

@ghost
Copy link

ghost commented Oct 5, 2023

No description provided.

@abdes
Copy link
Owner

abdes commented Oct 5, 2023

I see the same on the CI builds. I don't have the environment for testing this myself. Could you please build crypto++ manually using its Makefile and check if it's working?

I know the preprocessor logic has changed specifically for clang in 8.9.0 in crypto++ (not ceyptopp-cmake). But we don't see any issue on Linux or Mac clang builds.

@abdes
Copy link
Owner

abdes commented Oct 5, 2023

We'll leave it open until weidai11/cryptopp#1241 is solved. Sometimes there are side effects of fixes in crypto++ that require changes to cmake files...

@abdes abdes closed this as completed in 80d24bb Oct 15, 2023
@abdes
Copy link
Owner

abdes commented Oct 15, 2023

This is now fixed in the master branch of cryptopp-cmake. However, because cryptopp-cmake tracks the released version of crypto, it will not be reflected in the build unless you are building with the master branch of crypto using the CRYPTOPP_SOURCES make variable.

Once cryptopp version is released with the fixes made there, this project will release a new tracking version as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant