Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audk does not apply Uncrustify on commit, and has at least some crusty files #2345

Open
mikebeaton opened this issue Nov 4, 2023 · 0 comments
Open

audk does not apply Uncrustify on commit, and has at least some crusty files #2345

mikebeaton opened this issue Nov 4, 2023 · 0 comments
Labels
priority:normal project:oc

Comments

@mikebeaton
Copy link
Contributor

While working on acidanthera/OpenCorePkg#498 I noticed that https://github.com/acidanthera/audk/blob/master/MdePkg/Library/BasePeCoffLib2/PeCoffInit.c at least (and probably some other files) fails Uncrustify.

I'm not sure whether EDK-II files in general currently pass Uncrustify tests (as opposed to Microsoft Project Mu)? If so, then it would be an oversight that some audk files don't.

Naively applying the OpenCore Uncrustify workflow to audk (fork), seems to break Uncrustify before it completes - apparently an Uncrustify bug: https://github.com/mikebeaton/audk/actions/runs/6748885330/job/18348152462
@mikebeaton mikebeaton changed the title audk does not apply Uncrustify on commit, and has at least come crusty files audk does not apply Uncrustify on commit, and has at least some crusty files Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:normal project:oc
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vit9696 @mikebeaton