Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source selector for buttons is incorrect #310

Open
vdua opened this issue Oct 21, 2024 · 0 comments
Open

Source selector for buttons is incorrect #310

vdua opened this issue Oct 21, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@vdua
Copy link
Collaborator

vdua commented Oct 21, 2024

Description
If a button has content inside it (for instance icon or a label) and that icon/label is clicked, then the selector returned is incorrect. For example consider the HTML

<button id="btn-id">
        <span class="btn-icon-label">Button Label</span>
</button>

<div id="btn-id">
        <button class="btn-icon-label">Button Label</button>
</div>

If any of the btn-icon-label is clicked, the sourceSelector returned is #btn-id button.btn-icon-label. This selector points to the second button indicating that the first button is not clicked.

To Reproduce
Steps to reproduce the behavior:
Added a failing test case for the same

Expected behavior
The correct selector should be sent to RUM for further analysis of the data. i.e. form button#guideContainer-rootPanel-panel-panel-panel_1038605610-panel-guidebutton_copy___widget .iconButton-label

@vdua vdua added the bug Something isn't working label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant