Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom config json file #5535

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Support custom config json file #5535

merged 1 commit into from
Aug 30, 2024

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Aug 29, 2024

related: #5510

@llxia
Copy link
Contributor Author

llxia commented Aug 29, 2024

@llxia llxia requested review from pshipton and LongyuZhang August 29, 2024 19:47
LongyuZhang
LongyuZhang approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

karianna
karianna reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we also able to do an external run to test for regression?

@llxia
Copy link
Contributor Author

llxia commented Aug 29, 2024 •
edited
Loading

This does not affect external runs. The feature is only enabled if the special parameters are set.
If the external run wants this feature, we can address it in a separate issue.

@LongyuZhang LongyuZhang merged commit 6fc63d4 into adoptium:master Aug 30, 2024
2 checks passed
llxia added a commit to llxia/aqa-tests that referenced this pull request Aug 30, 2024
@llxia
Support custom config json file (adoptium#5535)
d388a97 
related: adoptium#5510

Signed-off-by: Lan Xia <[email protected]>
@llxia llxia mentioned this pull request Aug 30, 2024
Merged
LongyuZhang pushed a commit that referenced this pull request Aug 30, 2024
@llxia
Support custom config json file (#5535) (#5537)
b77c5c3 
related: #5510

Signed-off-by: Lan Xia <[email protected]>
llxia added a commit to llxia/aqa-tests that referenced this pull request Aug 30, 2024
@llxia
Support custom config json file (adoptium#5535)
05e2db9 
related: adoptium#5510

Signed-off-by: Lan Xia <[email protected]>
@llxia llxia mentioned this pull request Aug 30, 2024
Merged
LongyuZhang pushed a commit that referenced this pull request Aug 30, 2024
@llxia
Support custom config json file (#5535) (#5538)
1a63a4f 
related: #5510

Signed-off-by: Lan Xia <[email protected]>
llxia added a commit to llxia/aqa-tests that referenced this pull request Sep 6, 2024
@llxia
Support custom config json file (adoptium#5535)
8177740 
related: adoptium#5510

Signed-off-by: Lan Xia <[email protected]>
@llxia llxia mentioned this pull request Sep 6, 2024
Merged
pshipton pushed a commit that referenced this pull request Sep 6, 2024
@llxia @pshipton
Support custom config json file (#5535)
8b5c552 
related: #5510

Signed-off-by: Lan Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LongyuZhang LongyuZhang LongyuZhang approved these changes

@karianna karianna karianna approved these changes

@pshipton pshipton Awaiting requested review from pshipton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@llxia @karianna @LongyuZhang