From 6635a6c9d953894b73b83d50515d4ff15ede92cd Mon Sep 17 00:00:00 2001 From: Jiri Date: Thu, 31 Oct 2024 18:07:48 +0100 Subject: [PATCH 1/3] Document missing disable-adopt-branch-safety --- makejdk-any-platform.1 | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/makejdk-any-platform.1 b/makejdk-any-platform.1 index ddb1658dd..430f7f614 100755 --- a/makejdk-any-platform.1 +++ b/makejdk-any-platform.1 @@ -70,8 +70,8 @@ For reference, OpenJDK version numbers look like 1.8.0_162-b12 (for Java 8) or 9.0.4+11 (for Java 9+) with the build number being the suffix at the end. .TP .BR \-\-build-variant " " \fI\fR -specify a OpenJDK build variant, e.g. openj9. -For reference, the default variant is hotspot and does not need to be specified. +specify a OpenJDK build variant, e.g. openj9 or temurin. +For reference, the default variant is \fBhotspot\fR and does not need to be specified. .TP .BR \-c ", " \-\-clean-docker-build removes the existing docker container and persistent volume before starting @@ -106,6 +106,9 @@ It is known issue: https://github.com/adoptium/temurin-build/issues/3862 .BR \-\-debug-docker debug OpenJDK build script in a docker container. Only valid if \fB-D\fR is selected. .TP +.BR \-\-disable-adopt-branch-safety +disable the default check for tags/branches in case of \fBtemurin\fR as --build-variant. +.TP .BR \-\-disable-shallow-git-clone disable the default \fB--depth=1\fR shallow cloning of git repo(s). .TP From 0a4e0fcbc799dea680f505430c181ac7a7cf4353 Mon Sep 17 00:00:00 2001 From: judovana Date: Fri, 1 Nov 2024 09:07:29 +0100 Subject: [PATCH 2/3] mentioned impact on tarballs/dirs --- makejdk-any-platform.1 | 1 + 1 file changed, 1 insertion(+) diff --git a/makejdk-any-platform.1 b/makejdk-any-platform.1 index 430f7f614..be661415e 100755 --- a/makejdk-any-platform.1 +++ b/makejdk-any-platform.1 @@ -108,6 +108,7 @@ debug OpenJDK build script in a docker container. Only valid if \fB-D\fR is sele .TP .BR \-\-disable-adopt-branch-safety disable the default check for tags/branches in case of \fBtemurin\fR as --build-variant. +This is mandatory, when you are building \fBtemurin\fR variant from archive or directory without repository metadata. .TP .BR \-\-disable-shallow-git-clone disable the default \fB--depth=1\fR shallow cloning of git repo(s). From 5d593e76418ef0129279d602fc5493d61889b482 Mon Sep 17 00:00:00 2001 From: judovana Date: Thu, 7 Nov 2024 11:02:36 +0100 Subject: [PATCH 3/3] added README.JAVASE and removed mentioning of branches --- makejdk-any-platform.1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/makejdk-any-platform.1 b/makejdk-any-platform.1 index be661415e..6251c26b1 100755 --- a/makejdk-any-platform.1 +++ b/makejdk-any-platform.1 @@ -107,7 +107,7 @@ It is known issue: https://github.com/adoptium/temurin-build/issues/3862 debug OpenJDK build script in a docker container. Only valid if \fB-D\fR is selected. .TP .BR \-\-disable-adopt-branch-safety -disable the default check for tags/branches in case of \fBtemurin\fR as --build-variant. +disable the default check for correct tags and README.JAVASE in case of \fBtemurin\fR as --build-variant. This is mandatory, when you are building \fBtemurin\fR variant from archive or directory without repository metadata. .TP .BR \-\-disable-shallow-git-clone