Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot properly trap SIGINT #95

Open
Nan0Scho1ar opened this issue Jun 18, 2022 · 3 comments · May be fixed by #138
Open

Cannot properly trap SIGINT #95

Nan0Scho1ar opened this issue Jun 18, 2022 · 3 comments · May be fixed by #138

Comments

@Nan0Scho1ar
Copy link

I am trying to trap SIGINT in my ahoy cmd to kill a process gracefully, but ahoy dumps me straight back into the shell as soon as I hit Ctrl-C. I have also tried setting a custom bash entrypoint to trap SIGINT then manually call kill -SIGINT $child_process in an attempt to prevent this. Both options seems to receive and trap the interrupt thus calling the clean up code. However, because ahoy has already dropped me back into the shell (and printed the PS1 etc) the cleanup output makes quite a mess of my terminal.

The trap/cleanup functionality works perfectly fine (no mess) when not called using ahoy.

Is is possible for ahoy to pass on the SIGINT to the child process without being immediately dropped back into the shell?

@ocean
Copy link
Member

ocean commented Jun 20, 2022

Hi @Nan0Scho1ar and thanks for your issue.

I'm one of the new maintainers that have just been added to the project, I use ahoy daily and am interested in improving its capabilities for other users.

At present we are focusing on some chores such as getting the current code and dependencies updated to recent Go modules, and getting a new release out with those updates.

We can continue the discussion about your issue here, but I'm just letting you know it may not be actioned straight away.

@AlexSkrypnyk

This comment was marked as outdated.

@jackwrfuller
Copy link
Contributor

@ocean @AlexSkrypnyk

From some preliminary research, it looks like this issue is addressed by v2 of urfave/cli: urfave/cli#975.

If we do end up proceeding with migrating ahoy to v2 of urfave/cli, then it I think we solve this one for free.

@jackwrfuller jackwrfuller linked a pull request Jan 13, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants