Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle configuration conversion failures explicitly #373

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

BLYKIM
Copy link
Contributor

@BLYKIM BLYKIM commented Dec 18, 2024

Close: #359

@BLYKIM BLYKIM requested a review from sophie-cluml December 18, 2024 07:46
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 5 lines in your changes missing coverage. Please review.

Project coverage is 71.32%. Comparing base (b5e1348) to head (c57d670).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/graphql/node/input.rs 85.71% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #373   +/-   ##
=======================================
  Coverage   71.32%   71.32%           
=======================================
  Files          67       67           
  Lines       14661    14679   +18     
=======================================
+ Hits        10457    10470   +13     
- Misses       4204     4209    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BLYKIM BLYKIM force-pushed the bly/handle_conversion branch from 2450356 to cecb2dd Compare December 19, 2024 02:24
@BLYKIM BLYKIM force-pushed the bly/handle_conversion branch from cecb2dd to d398d76 Compare December 27, 2024 07:42
@sehkone
Copy link
Contributor

sehkone commented Jan 13, 2025

@BLYKIM, could you rebase this? Rust has been updated.

@BLYKIM BLYKIM force-pushed the bly/handle_conversion branch from d398d76 to c57d670 Compare January 13, 2025 06:12
@sehkone
Copy link
Contributor

sehkone commented Jan 13, 2025

@sophie-cluml, @BLYKIM

As I mentioned here, I think we need to include returning specific information about which agents caused the failures. If you agree, could you create an issue for it?

@sehkone
Copy link
Contributor

sehkone commented Jan 13, 2025

@BLYKIM @sophie-cluml,

Since the commit title exceeds the limit according to our rules, I modified it.

@sehkone sehkone merged commit f7c31d6 into main Jan 13, 2025
10 checks passed
@sehkone sehkone deleted the bly/handle_conversion branch January 13, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not treat conversion failure to Config as None
3 participants