Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DA-Related Functions for Blob Integrity and Fix WASM Test Case Bugs #24

Open
ComputerKeeda opened this issue Dec 16, 2024 · 7 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@ComputerKeeda
Copy link
Member

The Junction platform requires enhancements in its Data Availability (DA) layer to incorporate blob integrity checks, alongside addressing bugs in the WASM module test cases. These updates will bolster data reliability and ensure seamless functionality of the WASM module within the Junction ecosystem.


Proposed Enhancements

DA-Related Functions

  1. Log Blob Data
    • Add a function to log blob data for traceability and auditability.
  2. Post Blob ID
    • Implement a function to register Blob IDs, enabling robust blob data management and integrity validation.

WASM Test Case Fixes

  1. Resolve existing bugs in WASM-related test cases to ensure functionality validation.
  2. Develop additional test cases to cover edge scenarios and enhance reliability.

Current Gaps and Issues

Blob Data Handling

  • The DA layer lacks essential functions for logging and validating blob data, limiting the system's ability to ensure data integrity.

WASM Module Test Cases

  • Current test cases for the WASM module are incomplete or contain bugs, posing risks to production stability.

Proposed Solutions

For DA Layer

  1. LogBlobData
    • Develop and integrate a function to log blob data effectively.
  2. PostBlobID
    • Create a function to register Blob IDs for validation and tracking.
  3. Ensure both functions are optimized for efficient blob data handling and validation.

For WASM Module

  1. Identify and resolve bugs in existing WASM module test cases.
  2. Write new test cases to cover untested edge scenarios.
  3. Validate the updated test suite to ensure comprehensive coverage.

Acceptance Criteria

  1. Fully implemented LogBlobData and PostBlobID functions in the DA layer.
  2. Resolved all bugs in existing WASM module test cases.
  3. New WASM test cases covering edge scenarios successfully executed.
  4. Verified blob integrity checks and WASM module reliability in production environments.
@ComputerKeeda ComputerKeeda added bug Something isn't working enhancement New feature or request labels Dec 16, 2024
@saatvik333
Copy link
Contributor

So this is going to be patch-2, right?

@kritarth1107
Copy link
Member

Right, patch-1 is already merged.

@saatvik333
Copy link
Contributor

Okay, tbh I'm not entirely sure what we're supposed to do with the PostBlobID function since it seems while we are simply saving blob IDs, we do not intend to check them against any checksums or hashes, for that matter.

@kritarth1107
Copy link
Member

Actually, we’re not planning to just stop with preservation. The function PostBlobID will entail a module that would be responsible for verification. It wouldn't just be a simple checksum calculating, it would in fact, call for an appropriate integrity check validating function depending on the type of DA.

@saatvik333
Copy link
Contributor

It makes sense, but implementing that internal logic will mean changing the current DA functionality where the hash is saved along with the blob ID.

So my question is, do we have the capacity to do so at the moment, or are we to do it any other way, for example, in phases, like first implementing the logging functionality? Then, the hashing check will be built during the next iteration.

@ComputerKeeda
Copy link
Member Author

Let’s focus on logging and retention of the blob IDs for the time being but formulate a framework that will allow validation to be incorporated in the future without significant reworking.

@ComputerKeeda
Copy link
Member Author

Hey guys checkout 1c1966e this wraps up the test cases issues let me know if there is any issue in this

ComputerKeeda added a commit that referenced this issue Dec 23, 2024
…grity Checks (#6, #24)

- Added support for WASM integration to enable RUST-based contract deployment.  
- CipherPodLedger module, enabling FHE-based pod settlements in Junction.
- Implemented `LogBlobData` and `IntegrityCheck` functions to improve blob integrity in the DA layer.  
- Resolved bugs in WASM module test cases and added edge-case test coverage.  

Closes #6, #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants