Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension storage is full. #2192

Open
Morgyn opened this issue Jan 22, 2025 · 17 comments
Open

Extension storage is full. #2192

Morgyn opened this issue Jan 22, 2025 · 17 comments

Comments

@Morgyn
Copy link

Morgyn commented Jan 22, 2025

Receiving this error on every page:

Extension storage is full. Please delete some unsubmitted segments in the options.

I check for unsubmitted segments, and I have none:

You currently have no unsubmitted segments

Firefox 134.0.2
SponsorBlock 5.11.2

Has only just started happening, I suspect the latest update is causing this as it was updated on the same day the error appeared.

@Morgyn
Copy link
Author

Morgyn commented Jan 22, 2025

Reverted to 5.10.5 and message went away.

@ajayyy
Copy link
Owner

ajayyy commented Jan 22, 2025

My guess is your storage.local was already broken before, but only now are you being told about it. Maybe there is some about:config issue? If you uninstall/reinstall, does the problem fix itself?

@Morgyn
Copy link
Author

Morgyn commented Jan 22, 2025

Uninstall and Reinstall does not work.

I don't have anything wacky changed in my about:config.

I will try a manual removal of the sqlite.

@ajayyy
Copy link
Owner

ajayyy commented Jan 22, 2025

https://github.com/ajayyy/SponsorBlock/releases/tag/5.11.3

Made a release that adds more detail to the error and should make it only trigger when trying to make segments, not on every page load.

But Firefox is slow at reviewing, so it might not get deployed for 14 days+

For now, if you are experiencing this, you can downgrade

@Morgyn
Copy link
Author

Morgyn commented Jan 22, 2025

Will Keep my eye out for it,

A console debug message when the alert is raised would be handy, took me a little while to realise it was this extension that raised it. The only clue was the mention of segments.

@easonwong-de
Copy link

Firefox add-on reviewal is sooooo slow nowadays fr :(

Thanks for the great add-on, by the way! Let’s wait for the update together.

@robertsmieja
Copy link

What information would be useful to debug this?
Is there a small JavaScript snippet I could run in the browser console?

@ajayyy
Copy link
Owner

ajayyy commented Jan 23, 2025

@robertsmieja Go to about:debugging#/runtime/this-firefox, click inspect on SponsorBlock

Type the following in the console

chrome.storage.local.set({
            ["test"]: false
        }, () => {
            const error = chrome.runtime.lastError;
            if (error) {
                console.log(error)
            }
        });

@indeskyz
Copy link

@ajayyy I ran your code as I am having the same error - same env versions as the op as well for my firefox and sponsorblock

This is my output - I slightly adjusted the code and tried to look into the chrome runtime but didn't find anything useful:

I invoked the getLastError method manually and it returns empty(i dont know much abt firefox extension dev but i dont see anything obvious)

Output: Error: An unexpected error occurred

chrome.storage.local.set({
            ["test"]: false
        }, () => {
            const error = chrome.runtime.lastError;
            const { runtime } = chrome;
            if (error) {
                console.log('new error found :: ',error)
                console.log('-------')
                console.log('runtime during error ::', runtime);
            }
        });

posting for posterity as i just ignore the error as my browser is running fine (so far after ~1hr of messing around on youtube )

@ajayyy
Copy link
Owner

ajayyy commented Jan 23, 2025

hmm, so it gave an error before even getting to the log messages?

@indeskyz
Copy link

hmm, so it gave an error before even getting to the log messages?

looks to be the case - the error is null in the chrome.runtime when accessing the getLastError method. unsure what is happening

@londek
Copy link

londek commented Jan 23, 2025

Hey, same issue here.
chrome.runtime.lastError in my case is also Error: An unexpected error occurred.
Simply ignoring error after navigating to youtube.com works fine, I can't yet see any bugs.
This has started appearing RIGHT AFTER update to 134. I am user of Zen Browser which is Firefox based alternative to Arc.
1.7.2b (Firefox 134.0.2) (64-bit)

@robertsmieja
Copy link

robertsmieja commented Jan 23, 2025

@robertsmieja Go to about:debugging#/runtime/this-firefox, click inspect on SponsorBlock

Type the following in the console

chrome.storage.local.set({
["test"]: false
}, () => {
const error = chrome.runtime.lastError;
if (error) {
console.log(error)
}
});

Image

I am able to get the error consistently on Firefox. I'll edit this if I can figure out how to do this on YouTube.com itself (including the homepage, not sure if that helps).

EDIT: ha, managed to catch something via setting a breakpoint inside the extension, while on YouTube.com.

​
fileName: "undefined"
​
lineNumber: 0
​
message: "An unexpected error occurred"
​
stack: "Async*forceLocalUpdate@moz-extension://8c627bd8-27f8-4bf3-bb48-3ffe87d3e833/js/content.js:2:151414\n3683/t.setupVideoModule/<@moz-extension://8c627bd8-27f8-4bf3-bb48-3ffe87d3e833/js/content.js:2:173074\npromise callback*3683/t.setupVideoModule@moz-extension://8c627bd8-27f8-4bf3-bb48-3ffe87d3e833/js/content.js:2:172985\n6069@moz-extension://8c627bd8-27f8-4bf3-bb48-3ffe87d3e833/js/content.js:2:243297\nn@moz-extension://8c627bd8-27f8-4bf3-bb48-3ffe87d3e833/js/content.js:2:375188\n@moz-extension://8c627bd8-27f8-4bf3-bb48-3ffe87d3e833/js/content.js:2:375228\n@moz-extension://8c627bd8-27f8-4bf3-bb48-3ffe87d3e833/js/content.js:2:375236\n"
​
<prototype>: Error.prototype

Image

setInterval handler*1108/t.waitFor/</<@moz-extension://8c627bd8-27f8-4bf3-bb48-3ffe87d3e833/js/content.js:2:159871
1108/t.waitFor/<@moz-extension://8c627bd8-27f8-4bf3-bb48-3ffe87d3e833/js/content.js:2:159655
1108/n</<@moz-extension://8c627bd8-27f8-4bf3-bb48-3ffe87d3e833/js/content.js:2:159415
1108/n<@moz-extension://8c627bd8-27f8-4bf3-bb48-3ffe87d3e833/js/content.js:2:159160
1108/t.waitFor@moz-extension://8c627bd8-27f8-4bf3-bb48-3ffe87d3e833/js/content.js:2:159608
3683/t.setupVideoModule@moz-extension://8c627bd8-27f8-4bf3-bb48-3ffe87d3e833/js/content.js:2:172960
6069@moz-extension://8c627bd8-27f8-4bf3-bb48-3ffe87d3e833/js/content.js:2:243297
n@moz-extension://8c627bd8-27f8-4bf3-bb48-3ffe87d3e833/js/content.js:2:375188
@moz-extension://8c627bd8-27f8-4bf3-bb48-3ffe87d3e833/js/content.js:2:375228
@moz-extension://8c627bd8-27f8-4bf3-bb48-3ffe87d3e833/js/content.js:2:375236
1740/forceLocalUpdate/<@moz-extension://8c627bd8-27f8-4bf3-bb48-3ffe87d3e833/js/content.js:2:151458
Async*forceLocalUpdate@moz-extension://8c627bd8-27f8-4bf3-bb48-3ffe87d3e833/js/content.js:2:151414
3683/t.setupVideoModule/<@moz-extension://8c627bd8-27f8-4bf3-bb48-3ffe87d3e833/js/content.js:2:173074
promise callback*3683/t.setupVideoModule@moz-extension://8c627bd8-27f8-4bf3-bb48-3ffe87d3e833/js/content.js:2:172985
6069@moz-extension://8c627bd8-27f8-4bf3-bb48-3ffe87d3e833/js/content.js:2:243297
n@moz-extension://8c627bd8-27f8-4bf3-bb48-3ffe87d3e833/js/content.js:2:375188
@moz-extension://8c627bd8-27f8-4bf3-bb48-3ffe87d3e833/js/content.js:2:375228
@moz-extension://8c627bd8-27f8-4bf3-bb48-3ffe87d3e833/js/content.js:2:375236

@robertsmieja
Copy link

robertsmieja commented Jan 23, 2025

FWIW that debug page you pointed me doesn't seem to suffer from the issue.

I tried window.location.href="https://www.youtube.com" and it seemed to "load" just fine.
I'm not familiar with browser extension development or that debug page, but if want me to run any additional diagnostics (or load a source/developer version of the extension) I'd be happy to do so.

EDIT: forgot to mention I'm on extension version 5.11.2, Windows 11, Firefox 134.0.1 (with an update pending apparently).

@ajayyy
Copy link
Owner

ajayyy commented Jan 23, 2025

Quality firefox error messages

@ajayyy
Copy link
Owner

ajayyy commented Jan 23, 2025

I found this old bugzilla but it doesn't have much information https://bugzilla.mozilla.org/show_bug.cgi?id=1601365

@wolfkin
Copy link

wolfkin commented Jan 25, 2025

https://github.com/ajayyy/SponsorBlock/releases/tag/5.11.3

Made a release that adds more detail to the error and should make it only trigger when trying to make segments, not on every page load.

But Firefox is slow at reviewing, so it might not get deployed for 14 days+

For now, if you are experiencing this, you can downgrade

Firefox 134.0.2 (64-bit)
Edition Windows 10 Pro
Version 22H2
OS build 19045.5371
Experience Windows Feature Experience Pack 1000.19060.1000.0

5.11.3 installed as a Beta rather than updating the current extension. So two are listed in my "Manage Extensions". That said once I disabled the standard and left the beta by itself the alert didn't show up. I disabled the Beta and reenabled the standard and the error came back right away. For now I guess I'm rocking the beta until Firefox gets the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants