Skip to content
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.

Fix stale deployment data after create/delete deployment #64

Open
jtary opened this issue Mar 9, 2023 · 1 comment
Open

Fix stale deployment data after create/delete deployment #64

jtary opened this issue Mar 9, 2023 · 1 comment
Labels
bug Something isn't working product/console ready-for-community-dev This issue is ready for someone in the community to work on sev2

Comments

@jtary
Copy link
Contributor

jtary commented Mar 9, 2023

Describe the bug
When you access the deployment list page, you'll see the data from the last fetch for several seconds before its updated. While this is ideal for general access, it can be confusing if you've just deleted or created a deployment as those changes won't be reflected right away. There is also no indication on the page that anything is happening.

To Reproduce
Steps to reproduce the behavior:

  1. Go to deployments
  2. Click on an active deployment
  3. Close the deployment
  4. Return to deployment list
  5. Observe stale data

Expected behavior
After any operation that would change the deployment list, the query data needs to be invalidated/updated before control is handed back to the user. This ensures that when the visit the deployment list next, they won't be presented with stale data.

@jtary jtary added bug Something isn't working sev2 labels Mar 9, 2023
@anilmurty anilmurty added the ready-for-community-dev This issue is ready for someone in the community to work on label Apr 13, 2023
@jtary
Copy link
Contributor Author

jtary commented Apr 13, 2023

To fix this, a forced call to refrech is required. On the deployment details page, the refetch action can be requested with the useQuery hook for 'fetch-deployments', and that should be called and awaited after he delete to ensure the data is not stale.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working product/console ready-for-community-dev This issue is ready for someone in the community to work on sev2
Projects
None yet
Development

No branches or pull requests

2 participants