Build for macOS #292

dvkch · 2022-06-22T14:44:03Z

dvkch
Jun 22, 2022

Hello,

I'm currently looking into building this for macOS and haven't been very successful yet.

The first thing I noticed was that I'd need to build avahi first, as it is not available by default for macOS. I was able to do so using the following commands :

./configure --disable-qt5 --disable-gtk3 --disable-dbus --disable-gdbm --disable-libdaemon --disable-pygobject CFLAGS=-D__APPLE_USE_RFC_2292 --prefix=(pwd)/build
make
make install

As expected the required header and library files appeared in ./build :

build/
├── include
│   ├── avahi-common
│   │   ├── address.h
│   │   ├── alternative.h
│   │   ├── cdecl.h
│   │   ├── defs.h
│   │   ├── domain.h
│   │   ├── error.h
│   │   ├── gccmacro.h
│   │   ├── llist.h
│   │   ├── malloc.h
│   │   ├── rlist.h
│   │   ├── simple-watch.h
│   │   ├── strlst.h
│   │   ├── thread-watch.h
│   │   ├── timeval.h
│   │   └── watch.h
│   ├── avahi-core
│   │   ├── core.h
│   │   ├── log.h
│   │   ├── lookup.h
│   │   ├── publish.h
│   │   └── rr.h
│   └── avahi-glib
│       ├── glib-malloc.h
│       └── glib-watch.h
└── lib
    ├── libavahi-common.3.dylib
    ├── libavahi-common.a
    ├── libavahi-common.dylib -> libavahi-common.3.dylib
    ├── libavahi-common.la
    ├── libavahi-core.7.dylib
    ├── libavahi-core.a
    ├── libavahi-core.dylib -> libavahi-core.7.dylib
    ├── libavahi-core.la
    ├── libavahi-glib.1.dylib
    ├── libavahi-glib.a
    ├── libavahi-glib.dylib -> libavahi-glib.1.dylib
    └── libavahi-glib.la

5 directories, 34 files

I then went on to build airscan, and to add some defines in airscan.h :

#ifdef __APPLE__
#include <machine/endian.h>
#include <libkern/OSByteOrder.h>

#define htobe16(x) OSSwapHostToBigInt16(x)
#define htole16(x) OSSwapHostToLittleInt16(x)
#define be16toh(x) OSSwapBigToHostInt16(x)
#define le16toh(x) OSSwapLittleToHostInt16(x)

#define htobe32(x) OSSwapHostToBigInt32(x)
#define htole32(x) OSSwapHostToLittleInt32(x)
#define be32toh(x) OSSwapBigToHostInt32(x)
#define le32toh(x) OSSwapLittleToHostInt32(x)

#define htobe64(x) OSSwapHostToBigInt64(x)
#define htole64(x) OSSwapHostToLittleInt64(x)
#define be64toh(x) OSSwapBigToHostInt64(x)
#define le64toh(x) OSSwapLittleToHostInt64(x)

#define __BIG_ENDIAN    BIG_ENDIAN
#define __LITTLE_ENDIAN LITTLE_ENDIAN
#define __BYTE_ORDER    BYTE_ORDER
#include "memrchr.h"
#endif

memrchr was added from https://github.com/st3fan/osx-10.9/blob/master/sudo-72/src/memrchr.c .

I also had to rename the sane_* functions since __attribute__ ((alias ("function_name"))) doesn't seem to compile properly on macOS.

The build command looks like this :

C_INCLUDE_PATH=/path/to/avahi/build/include/avahi-common:/path/to/sane-backends/include/ LD_LIBRARY_PATH=/path/to/avahi/build/lib/  make

I am now face with the following errors :


Package avahi-client was not found in the pkg-config search path.
Perhaps you should add the directory containing `avahi-client.pc'
to the PKG_CONFIG_PATH environment variable
No package 'avahi-client' found
Package avahi-client was not found in the pkg-config search path.
Perhaps you should add the directory containing `avahi-client.pc'
to the PKG_CONFIG_PATH environment variable
No package 'avahi-client' found
ctags -R .
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ctags: illegal option -- R
usage: ctags [-BFadtuwvx] [-f tagsfile] file ...
make: [tags] Error 1 (ignored)
mkdir -p objs/
gcc -c -o objs/airscan.o airscan.c  -O2 -g -W -Wall -Werror -pthread  -D CONFIG_SANE_CONFIG_DIR=\"/usr/local/etc/sane.d\"      -I/opt/homebrew/Cellar/gnutls/3.7.6/include -I/opt/homebrew/Cellar/nettle/3.7.3/include -I/opt/homebrew/Cellar/libtasn1/4.18.0/include -I/opt/homebrew/Cellar/libidn2/2.3.2/include -I/opt/homebrew/Cellar/p11-kit/0.24.1/include/p11-kit-1  -I/opt/homebrew/Cellar/jpeg/9e/include  -I/opt/homebrew/Cellar/libpng/1.6.37/include/libpng16 -fPIC
In file included from airscan.c:9:
./airscan.h:100:16: error: declaration of 'struct log_ctx' will not be visible outside of this function [-Werror,-Wvisibility]
typedef struct log_ctx log_ctx;
               ^
./airscan.h:100:1: error: invalid storage class specifier in function declarator
typedef struct log_ctx log_ctx;
^
./airscan.h:100:24: error: parameter named 'log_ctx' is missing
typedef struct log_ctx log_ctx;
                       ^
./airscan.h:104:16: error: declaration of 'struct http_uri' will not be visible outside of this function [-Werror,-Wvisibility]
typedef struct http_uri http_uri;
               ^
./airscan.h:104:1: error: invalid storage class specifier in function declarator
typedef struct http_uri http_uri;
^
./airscan.h:104:25: error: parameter named 'http_uri' is missing
typedef struct http_uri http_uri;
                        ^
./airscan.h:124:16: error: declaration of 'struct ll_node' will not be visible outside of this function [-Werror,-Wvisibility]
typedef struct ll_node ll_node;
               ^
./airscan.h:124:1: error: invalid storage class specifier in function declarator
typedef struct ll_node ll_node;
^
./airscan.h:124:24: error: parameter named 'll_node' is missing
typedef struct ll_node ll_node;
                       ^
./airscan.h:126:5: error: must use 'struct' tag to refer to type 'll_node'
    ll_node *ll_prev, *ll_next;
    ^
    struct 
./airscan.h:124:24: note: struct 'll_node' is hidden by a non-type declaration of 'll_node' here
typedef struct ll_node ll_node;
                       ^
./airscan.h:125:1: error: declaration does not declare a parameter
struct ll_node {
^
./airscan.h:133:5: error: must use 'struct' tag to refer to type 'll_node'
    ll_node node;
    ^
    struct 
./airscan.h:124:24: note: struct 'll_node' is hidden by a non-type declaration of 'll_node' here
typedef struct ll_node ll_node;
                       ^
./airscan.h:132:1: error: invalid storage class specifier in function declarator
typedef struct {
^
./airscan.h:134:3: error: parameter named 'll_head' is missing
} ll_head;
  ^
./airscan.h:138:1: error: invalid storage class specifier in function declarator
static inline void ll_init (ll_head *head) {
^
./airscan.h:138:29: error: unknown type name 'll_head'
static inline void ll_init (ll_head *head) {
                            ^
./airscan.h:138:8: error: 'inline' can only appear on functions
static inline void ll_init (ll_head *head) {
       ^
./airscan.h:138:20: error: parameter named 'll_init' is missing
static inline void ll_init (ll_head *head) {
                   ^
./airscan.h:138:43: error: expected ';' at end of declaration
static inline void ll_init (ll_head *head) {
                                          ^
                                          ;
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make: *** [objs/airscan.o] Error 1

I'm weirdly surprised by this, as the log_ctx and http_uri forward declarations and the static inline functions seem valid, but I haven't done C development in a while and may probably have missing something. Maybe it only builds with gcc and I should try to build using it instead of clang ?

Thank you for your input

alexpevzner · 2022-06-22T15:48:28Z

alexpevzner
Jun 22, 2022
Maintainer

Hi,

I'm not very familiar with the MacOS development, so here I can rely only on my common sense. But we can try move step-by-step, don't hesitate to ask. The FreeBSD port was made in this mode, there was a long conversation finished with the successful port :-)

First thing that I see:

Package avahi-client was not found in the pkg-config search path.
Perhaps you should add the directory containing `avahi-client.pc'
to the PKG_CONFIG_PATH environment variable
No package 'avahi-client' found

I heavily rely on the pkg-config to find required compiler and linger flags to use the particular library. And it works everywhere, on Linux/FreeBSD/NetBSD/OpenBSD/... Looks like avahi-client libraries either unproperly installed on your machine, or not installed at all.

In file included from airscan.c:9:
./airscan.h:100:16: error: declaration of 'struct log_ctx' will not be visible outside of this function [-Werror,-Wvisibility]
typedef struct log_ctx log_ctx;

It looks like errors, caused by preceding changes in the airscan.h file. Something like unbalanced braces or similar. May be, in the newly #included file

Maybe it only builds with gcc and I should try to build using it instead of clang ?

No, it definitely builds by clang

0 replies

alexpevzner · 2022-06-22T17:20:54Z

alexpevzner
Jun 22, 2022
Maintainer

BTW, I expect problems with avahi, because MacOS has its own DNS-SD infrastructure, and Avahi may conflict with it, and expect problems in the airscan-wsdd.c file around UDP multicasting, because every UNIX tends to handle it on its own unique manner. But everything else should be more or less smooth.

If you will have to add some OS-specific #ifdef, it would be better to add OS_HAVE_XXX constant (look for OS_HAVE_EVENTFD as for example) and use it around the code rather that use #ifdef __APPLE__ everywhere.

We may communicate it, when things will get more specific.

0 replies

dvkch · 2022-06-22T20:34:56Z

dvkch
Jun 22, 2022
Author

Thank you so much for your answers ! I've been able to go further in the build by removing memrchr files and adding it properly in airscan.h.

The state of the modifications, for now, is :

remove __attribute__ ((alias ("function_name")))
add the following code in airscan.h

#ifdef __APPLE__
#include <machine/endian.h>
#include <libkern/OSByteOrder.h>

#define htobe16(x) OSSwapHostToBigInt16(x)
#define htole16(x) OSSwapHostToLittleInt16(x)
#define be16toh(x) OSSwapBigToHostInt16(x)
#define le16toh(x) OSSwapLittleToHostInt16(x)

#define htobe32(x) OSSwapHostToBigInt32(x)
#define htole32(x) OSSwapHostToLittleInt32(x)
#define be32toh(x) OSSwapBigToHostInt32(x)
#define le32toh(x) OSSwapLittleToHostInt32(x)

#define htobe64(x) OSSwapHostToBigInt64(x)
#define htole64(x) OSSwapHostToLittleInt64(x)
#define be64toh(x) OSSwapBigToHostInt64(x)
#define le64toh(x) OSSwapLittleToHostInt64(x)

#define __BIG_ENDIAN    BIG_ENDIAN
#define __LITTLE_ENDIAN LITTLE_ENDIAN
#define __BYTE_ORDER    BYTE_ORDER

#endif /* __APPLE__ */

#ifndef HAVE_MEMRCHR

#include <sys/types.h>

#ifndef SOCK_NONBLOCK
#include <fcntl.h>
# define SOCK_NONBLOCK O_NONBLOCK
#endif

#ifndef SOCK_CLOEXEC
#include <fcntl.h>
# define SOCK_CLOEXEC O_CLOEXEC
#endif


/*
 * Reverse memchr()
 * Find the last occurrence of 'c' in the buffer 's' of size 'n'.
 */
static inline void *
memrchr(const void *s, int c, size_t n)
{
    const unsigned char *cp;

    if (n != 0) {
       cp = (unsigned char *)s + n;
       do {
           if (*(--cp) == (unsigned char)c)
               return (void *)cp;
       } while (--n != 0);
    }
    return (void *)0;
}
#endif /* HAVE_MEMRCHR */

I was able to build way more files, and am now facing a conflict in uuid_parse definition :

In file included from airscan-os.c:14:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/pwd.h:110:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/uuid/uuid.h:68:5: error: conflicting types for 'uuid_parse'
int uuid_parse(const uuid_string_t in, uuid_t uu);
    ^
./airscan.h:918:1: note: previous declaration is here
uuid_parse (const char *in);
^
airscan-os.c:108:5: error: FIX ME
#   error FIX ME
    ^
2 errors generated.
make: *** [objs/airscan-os.o] Error 1

I'll stop here for tonight and keep you posted on how it goes in the coming days !

I've also realised I might need to find a better way to build avahi to actually build avahi-client. This is gonna be a tough one since I do plan on doing cross compiling for iOS at some point, and the amount of dependencies is starting to get complicated to manage :D

I've also taken note of the OS_HAVE_XXX mechanism and when I'll be able to make it build and will wrap up my changes in a PR I'll use them.

Thank you again a lot for your help !

0 replies

alexpevzner · 2023-07-07T13:21:59Z

alexpevzner
Jul 7, 2023
Maintainer

Converting it to discussion, because it doesn't contain any bug report or feature request...

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build for macOS #292

{{title}}

Replies: 4 comments

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

Build for macOS #292

dvkch Jun 22, 2022

Replies: 4 comments

alexpevzner Jun 22, 2022 Maintainer

alexpevzner Jun 22, 2022 Maintainer

dvkch Jun 22, 2022 Author

alexpevzner Jul 7, 2023 Maintainer

dvkch
Jun 22, 2022

alexpevzner
Jun 22, 2022
Maintainer

alexpevzner
Jun 22, 2022
Maintainer

dvkch
Jun 22, 2022
Author

alexpevzner
Jul 7, 2023
Maintainer