-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PushBullet.deletePush(pushId) #2
Comments
I believe this is an issue with PushBullet's end. Upon testing, I got the following:
This likely means that the PushBullet devs don't have the CORS headers properly configured. |
Yes, that's what I already thought. I also thought, maybe I missed something :P I will mail them to get it resorted, keep you informed :) |
I think alex already emailed me about this. Can you post the exact request here (all headers, you can edit out the access token) so I can debug the issue? |
I get a 400 Bad Request from Google Front End To reproduce, just a HTML page with included pushbullet-js script and the following code:
Here are all the details about the request:
|
I haven't tried to reproduce your error, but from the looks of it you're sending the payload "null". DELETE does not allow a payload and it looks like your request isn't getting to my server because the google front end servers are rejecting it as invalid. Could you try without the payload? |
Ahh. It looks like I finally get how GitHub works, sort of. The 'strangest' thing is that you need to always fork, even if you are not planning to do anything else than fixing a bug. Thanks @christopherhesse, that was the key :) |
Closing as this is already fixed |
Only send a payload if one is absolutely needed. Thanks @KoalaBear84
I've tested this again, because I had to delete some pushes. And it's the same problem again. I've solved it locally with the following: I thought this was already fixed and finished. :) |
Seriously? That makes no sense. How is it possible for parameters to equal "null"? I know that javascript has weak typing, but it can't be THAT weak. Do you mind giving me some sample code that replicates this problem? |
Sorry, little delay :) This should fail, and give a 500 Internal Server Error or something like that. // Delete first push
PushBullet.pushHistory(function(err, res) {
PushBullet.deletePush(res.pushes[0].iden);
}); |
Hi Alex, Any progress on the test framework? :) Thanks! |
I know, I've really been slacking on this. I'm working on finals this week, and I hope to really spend some time on all the projects I've been working on (this included), starting this weekend. |
Now? :P |
Ever? :) It's not that I wait on this. But I see it's still opened. |
When I'm doing this I get an error in the Chrome Console:
NetworkError: Failed to execute 'send' on 'XMLHttpRequest': Failed to load 'https://api.pushbullet.com/v2/pushes/pushId'.
This is because Google catches the error.
This is a part of the HTML:
400. That’s an error. ##
Your client has issued a malformed or illegal request. That’s all we know.
I don't know if this is because it does not work with HTTP DELETE, or another error.
If you need more information, let me know! Thanks.
The text was updated successfully, but these errors were encountered: