Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulation asserts failed when using HPCC #10

Closed
HeRaNO opened this issue Nov 6, 2024 · 0 comments · Fixed by #13
Closed

Simulation asserts failed when using HPCC #10

HeRaNO opened this issue Nov 6, 2024 · 0 comments · Fixed by #13

Comments

@HeRaNO
Copy link
Contributor

HeRaNO commented Nov 6, 2024

Reproduce

  1. Same as Heap buffer overflow when running simulation #6 with the potential fix mentioned.
  2. Turn on NS3_ASSERT (https://github.com/aliyun/ns-3-alibabacloud/blob/master/simulation/CMakeLists.txt#L32) and NS3_LOG (https://github.com/aliyun/ns-3-alibabacloud/blob/master/simulation/CMakeLists.txt#L35)
  3. Change CC_MODE to 3 (https://github.com/aliyun/SimAI/blob/master/astra-sim-alibabacloud/inputs/config/SimAI.conf#L14)
  4. Run the simulation

Logs

assert failed. cond="ih.nhop <= IntHeader::maxHop", +0.000559210s 116 file=/root/SimAI/astra-sim-alibabacloud/extern/network_backend/ns3-interface/simulation/src/point-to-point/model/rdma-hw.cc, line=954

Output ih.nhop shows:

nhop: 31245

If change the parallel thread from 3 to 1, the ih.nhop changes to

nhop: 23053

Potential Fix

https://github.com/aliyun/SimAI/blob/master/astra-sim-alibabacloud/astra-sim/network_frontend/ns3/common.h#L685

add else before this line.

@HeRaNO HeRaNO changed the title Simulation asserts when using HPCC Simulation asserts failed when using HPCC Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant