Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryLastPendingBatchRequestByAddr and QueryLastPendingLogicCallByAddr should both return arrays #330

Open
2 tasks
jkilpatr opened this issue Sep 8, 2021 · 0 comments
Labels
Gravity Module cosmos sdk module orchestrator relays messages between ETH <-> Cosmos

Comments

@jkilpatr
Copy link
Member

jkilpatr commented Sep 8, 2021

Right now

QueryLastPendingLogicCallByAddr

and
QueryLastPendingBatchRequestByAddr

return individual values, this crates a simple flow where the Orchestrator calls these endpoints, signs the latest result, and submits it.

This becomes a problem if batches or Logic calls are created faster than this loop operates. This actually has already been solved on the validator set flow, where we ran into this problem pretty quickly in our early testnets.

  • Modify the query endpoints to return arrays of values
  • Modify the orchestrator to submit signatures as a bundle of messages, preventing orchestrators from falling behind signing these newly created sets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gravity Module cosmos sdk module orchestrator relays messages between ETH <-> Cosmos
Projects
None yet
Development

No branches or pull requests

1 participant