-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDIM code doesn't work #44
Comments
The code is based on guided diffusion by OpenAI where there is an option to use DDIM. The line you mentioned is probably just a fragment of the old code that was left unnoticed. |
How did you solve this problem? |
@StonyB During the process of reusing the OpenAI repo for inpainting many unnecessary functions were removed (DDIM etc). If you need this functionality you would have to manually add them from the original OpenAI repository. Personally, I didn't need this functionality so I just removed DDIM parameter in config file |
@JackPieCZ if i want to use DDIM, how should i add? i am looking for it in "https://github.com/openai/guided-diffusion/blob/22e0df8183507e13a7813f8d38d51b072ca1e67c/guided_diffusion/gaussian_diffusion.py#L625" |
I saw the respace.py file creates a DDIM skip time step, but when I set the <use_ddim=true>, the code in the test.py file<sample_fn = (diffusion.p_sample_loop if not conf.use_ddim else diffusion.ddim_sample_loop)> does not work because there is no definition of the method <ddim_sample_loop>.
Is the DDIM code unfinished?
How does the DDIM skip_type work with the resampling schedule?
The text was updated successfully, but these errors were encountered: