Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build is failing though android:exported=true is being added to plugin.xml #298

Open
pankajjain15 opened this issue Dec 28, 2022 · 5 comments

Comments

@pankajjain15
Copy link

Hi

I have installed FCM plugin as per the instruction provided here

https://ionicframework.com/docs/native/fcm

I was getting the build error when I did ionic cordova build androind

image

I researched on this issue and found that , I have to add exported:true to the plugin.xml under node_modules\cordova-plugin-fcm-with-dependecy-updated

like below

<?xml version="1.0" encoding="UTF-8"?>
<!--
  Licensed to the Apache Software Foundation (ASF) under one
  or more contributor license agreements.  See the NOTICE file
  distributed with this work for additional information
  regarding copyright ownership.  The ASF licenses this file
  to you under the Apache License, Version 2.0 (the
  "License"); you may not use this file except in compliance
  with the License.  You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

  Unless required by applicable law or agreed to in writing,
  software distributed under the License is distributed on an
  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
  KIND, either express or implied.  See the License for the
  specific language governing permissions and limitations
  under the License.
-->
<plugin xmlns="http://apache.org/cordova/ns/plugins/1.0" id="cordova-plugin-fcm-with-dependecy-updated" version="7.8.0">
	<name>Cordova FCM Push Plugin</name>
	<description>Google Firebase Cloud Messaging Cordova Push Plugin fork with dependecy updated</description>
	<license>MIT</license>
	<keywords>notifications, push, firebase, fcm, ios, android, cordova, plugin</keywords>

	<js-module src="www/FCMPlugin.js" name="FCMPlugin">
		<clobbers target="FCM" />
	</js-module>

	<engines>
		<engine name="cordova" version=">=8.1.0" />
		<engine name="cordova-android" version=">=6.4.0" />
		<engine name="cordova-ios" version=">=5.0.0" />
	</engines>

	<!-- ANDROID CONFIGURATION -->
	<platform name="android">
		<preference name="ANDROID_DEFAULT_NOTIFICATION_ICON" default="@mipmap/ic_launcher" />
		<preference name="ANDROID_FCM_VERSION" default="21.0.0" />
		<preference name="ANDROID_FIREBASE_BOM_VERSION" default="26.0.0" />
		<preference name="ANDROID_GOOGLE_SERVICES_VERSION" default="4.3.4" />
		<preference name="ANDROID_GRADLE_TOOLS_VERSION" default="4.1.0" />

		<config-file target="AndroidManifest.xml" parent="/manifest/application">
			<activity android:exported="true" android:name="com.gae.scaffolder.plugin.FCMPluginActivity" android:launchMode="singleTop">
				<intent-filter>
					<action android:name="FCM_PLUGIN_ACTIVITY" />
					<category android:name="android.intent.category.DEFAULT" />
				</intent-filter>
			</activity>
			<service 
				android:name="com.gae.scaffolder.plugin.MyFirebaseMessagingService"
				android:stopWithTask="false"
				android:exported="true">
				<intent-filter>
					<action android:name="com.google.firebase.MESSAGING_EVENT"/>
				</intent-filter>
			</service>
			<meta-data android:name="com.google.firebase.messaging.default_notification_icon" android:resource="$ANDROID_DEFAULT_NOTIFICATION_ICON" />
		</config-file>
		<config-file target="res/xml/config.xml" parent="/*">
			<feature name="FCMPlugin">
				<param name="android-package" value="com.gae.scaffolder.plugin.FCMPlugin"/>
				<param name="onload" value="true" />
			</feature>
		</config-file>
		<config-file target="config.xml" parent="/*">
			<platform name="android">
				<preference name="AndroidXEnabled" value="true" />
			</platform>
		</config-file>
		<framework src="src/android/FCMPlugin.gradle" custom="true" type="gradleReference"/>

		<source-file src="src/android/com/gae/scaffolder/plugin/FCMPlugin.java" target-dir="src/com/gae/scaffolder/plugin" />
		<source-file src="src/android/com/gae/scaffolder/plugin/FCMPluginChannelCreator.java" target-dir="src/com/gae/scaffolder/plugin" />
		<source-file src="src/android/com/gae/scaffolder/plugin/MyFirebaseMessagingService.java" target-dir="src/com/gae/scaffolder/plugin" />
		<source-file src="src/android/com/gae/scaffolder/plugin/FCMPluginActivity.java" target-dir="src/com/gae/scaffolder/plugin" />
		<source-file src="src/android/com/gae/scaffolder/plugin/interfaces/OnFinishedListener.java" target-dir="src/com/gae/scaffolder/plugin/interfaces" />
		<source-file src="src/android/com/gae/scaffolder/plugin/interfaces/TokenListeners.java" target-dir="src/com/gae/scaffolder/plugin/interfaces" />
	</platform>

	<!-- IOS CONFIGURATION -->
	<platform name="ios">
		<preference name="IOS_FIREBASE_MESSAGING_VERSION" default="~> 7.4.0" />
		<config-file target="config.xml" parent="/*">
			<feature name="FCMPlugin">
				<param name="ios-package" value="FCMPlugin"/>
			</feature>
		</config-file>

		<!-- ENABLE PUSH CAPABILITY -->
		<config-file parent="aps-environment" target="*/Entitlements-Debug.plist">
			<string>development</string>
		</config-file>
		<config-file parent="aps-environment" target="*/Entitlements-Release.plist">
			<string>production</string>
		</config-file>
		<config-file target="*-Info.plist" parent="UIBackgroundModes">
			<array>
				<string>remote-notification</string>
			</array>
		</config-file>
		<config-file target="*-Info.plist" parent="FirebaseAppDelegateProxyEnabled">
			<false/>
		</config-file>

		<resource-file src="src/ios/Assets/GoogleService-Info.plist" target="Resources/GoogleService-Info.plist" />

		<header-file src="src/ios/FCMPlugin.h" />
		<source-file src="src/ios/FCMPlugin.m" />

		<header-file src="src/ios/AppDelegate+FCMPlugin.h" />
		<source-file src="src/ios/AppDelegate+FCMPlugin.m" />

		<header-file src="src/ios/FCMPluginIOS9Support.h" />
		<source-file src="src/ios/FCMPluginIOS9Support.m" />

		<header-file src="src/ios/FCMNotificationCenterDelegate.h" />
		<source-file src="src/ios/FCMNotificationCenterDelegate.m" />

		<!-- FIREBASE COCOAPODS-->
		<podspec>
			<config>
                <source url="https://github.com/CocoaPods/Specs.git"/>
			</config>
			<pods>
				<pod name="Firebase/Messaging" spec="$IOS_FIREBASE_MESSAGING_VERSION"/>
			</pods>
		</podspec>
	</platform>

	<!-- COPY FCM CONFIG FILES TO PLATFORM BEFORE COMPILING -->
	<hook src="scripts/copy_google_service_files.js" type="after_prepare" />
	<hook src="scripts/copy_google_service_files.js" type="after_plugin_add" />
	<hook src="scripts/install_ionic_dependencies.bat" type="after_plugin_install" />
</plugin>

But I am still facing the same issue. Kindly guide/advice

@briquetech
Copy link

I faced the same issue recently. Try removing the Android platform, making changes to the plugin.xml and then re-adding the platform. These sequence of steps worked for me.

@pankajjain15
Copy link
Author

@briquetech I tried above steps lot of times but didn't worked for me. Don't know what is happening .

@flyingcat42
Copy link

flyingcat42 commented Jan 10, 2023

@pankajjain15

  1. Remove your plugin
  2. Add plugin as per this comment's instructions Notification not getting received in Android 31 #293 (comment)
  3. Build
  4. If build fails:
    Open \platforms\android\app\src\main\AndroidManifest.xml find "com.gae.scaffolder" add android:exported="true" to <activity and <service. Then try to build. Sometimes, multiple and will get added for "com.gae.scaffolder", in that case, you'll have to remove the extra ones. After this, the build should work.

<activity android:exported="true" android:launchMode="singleTop" android:name="com.gae.scaffolder.plugin.FCMPluginActivity"> <intent-filter> <action android:name="FCM_PLUGIN_ACTIVITY" /> <category android:name="android.intent.category.DEFAULT" /> </intent-filter> </activity>

<service android:exported="true" android:name="com.gae.scaffolder.plugin.MyFirebaseMessagingService" android:stopWithTask="false"> <intent-filter> <action android:name="com.google.firebase.MESSAGING_EVENT" /> </intent-filter> </service>

@briquetech
Copy link

This double entry will not go away even if you remove the additional entry. Next time you build, the duplicate entry will return.

One more thing you can most definitely do is to upgrade the gradle version. This will definitely rid you of the exported issue.

@Senzo13
Copy link

Senzo13 commented Aug 31, 2023

Hello @briquetech I have exactly the same problem as @flyingcat42, regarding the version of gradle you are talking about, I updated mine to 7.2, but I still have the same problem, which version can solve it definitively this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants