Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to typescript #1

Open
andresoviedo opened this issue Sep 27, 2018 · 5 comments
Open

move to typescript #1

andresoviedo opened this issue Sep 27, 2018 · 5 comments

Comments

@andresoviedo
Copy link
Owner

No description provided.

@jmcdo29
Copy link

jmcdo29 commented Oct 1, 2018

Hi there, I see that you've already stated the move to TypeScript, can I help? Would you rather I fork or clone the repo?

@andresoviedo
Copy link
Owner Author

Hi. Yes. It would be nice.

I have already moved some classes.
New code is also compiling, but there is still work to do. Althought migration is very straightforward.

If you want to help that's great!
Please find current migration status in branch wip/typescript.

I would recommend to start moving class by class, then compile, then move another class and so on.

If you want, you can make a pull request to that branch when you feel you have made some progress.

Thanks,
Kind regards

@jmcdo29
Copy link

jmcdo29 commented Oct 1, 2018

It seems like with the current file structure it's not going to be possible to make it into Typescript without using a lot of "any" type, which kind of defeats the purpose. Would you want me to attempt to completely change the file structure to be more class-based or just leave it as is?

@andresoviedo
Copy link
Owner Author

Please :)

@jmcdo29
Copy link

jmcdo29 commented Oct 2, 2018

I may have bitten off a bit more than I can chew. I'll keep taking a look, but I may not be able to make any progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants