Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong module name #22

Open
jezek opened this issue Sep 23, 2024 · 1 comment
Open

Wrong module name #22

jezek opened this issue Sep 23, 2024 · 1 comment

Comments

@jezek
Copy link
Contributor

jezek commented Sep 23, 2024

This one is serious. I somehow messed up and now your go.mod file contains module github.com/jezek/chess instead of module github.com/andrewbackes/chess.

Also the line github.com/andrewbackes/chess v0.0.0-20171122002438-368c396b5300 should be not in require.

@jezek
Copy link
Contributor Author

jezek commented Sep 23, 2024

@andrewbackes I'm terribly sorry for my mistake. I made the mistake in PR #18 , I really don't know how I missed this. I hope you can forgive me.

How to handle the PR #23 ?

  1. Revert changes until Add go.mod & go.sum #18, amend the PR#23, merge Parse move tests & benchmarks #19 and PGN export with moves in SAN #20 again. Repair tags.
    Pros: History will be like it never happened.
    Cons: Other projects using this package could have trouble. More work resetting, amending and merging.

  2. Merge the PR Go mod is faulty #23, move tag v1.1.0 to last commit.
    Pros: No reverting & breaking history. Easy.
    Cons: Maybe some other projects using tag v1.1.0 could have trouble. Messing with tags.

  3. Merge the PR Go mod is faulty #23, add tag v1.1.1 to last commit.
    Pros: No reverting & breaking history. Easiest and "by the book".
    Cons: Tag v1.1.0 will be faulty forever.

I hope this helps to repair my mistake. Again, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant