You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Clamp the aspect ratio to the accepted range 2.39:1 - 1:2.39
Remove the line explicitly setting the aspect ratio
I'm inclined to guess we're not actually using the video size when calculating this aspect ratio - this might require setting up a listener to properly update the PiP window aspect ratio once ExoPlayer has finished preparing the video
The text was updated successfully, but these errors were encountered:
I noticed SociaLite was crashing when starting video playback in landscape orientation, and I think this line configuring the PiP window is causing the error: https://github.com/android/socialite/blob/main/app/src/main/java/com/google/android/samples/socialite/ui/player/VideoPlayerScreen.kt#L182
On the device I was testing with, it seems we're getting width 2340 and height 790, which is an aspect ratio of 2.96 and outside the 2.39:1 - 1:2.39 bounds that are accepted https://developer.android.com/reference/android/app/PictureInPictureParams.Builder#setAspectRatio%28android.util.Rational%29
Some possible solutions:
The text was updated successfully, but these errors were encountered: