Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check and show engine requirements (if there is one in package.json) #146

Open
3 tasks done
GeoffreyParrier opened this issue Dec 18, 2024 · 4 comments
Open
3 tasks done
Labels
enhancement New feature or request pr welcome

Comments

@GeoffreyParrier
Copy link

Clear and concise description of the problem

Currently we don't know if a package will be compatible with our current version of node on update.

Suggested solution

A new column with a copy of the engines.node field if it is defined in the package.json of each dependency.

Maybe make it clear if a dependency don't have a value with a "N/A" or something like this.

Alternative

No response

Additional context

Some idea extending this request:

  • A command to list current engines.node of each dependencies
  • A command to check if a node version (current by default) is compatible with our dependencies

Validations

@GeoffreyParrier GeoffreyParrier added the enhancement New feature or request label Dec 18, 2024
@antfu
Copy link
Member

antfu commented Dec 18, 2024

That would be cool! Would you like to draft a PR for it? Thanks

@GeoffreyParrier
Copy link
Author

Absolutely, I need to find some time for it but I would be happy to help, no promises though, so if someone want to take charge of this, it's fine for me too

@GeoffreyParrier
Copy link
Author

GeoffreyParrier commented Dec 20, 2024

@antfu Do you think it would be ok if I make a PR to update fast-npm-meta to handle package.json engines too ?

@antfu
Copy link
Member

antfu commented Dec 21, 2024

Yeah sure, please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pr welcome
Projects
None yet
Development

No branches or pull requests

2 participants