fix(cli): Make Shortest compatible with Windows #256
Conversation
|
@PedroAVJ is attempting to deploy a commit to the Antiwork Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
@PedroAVJ are the changes from this file needed for Windows compatibility?
There was a problem hiding this comment.
I also had to fix some issues with page.evaluate. Apparently __name is not defined due to how esbuild works, and was causing the tests to crash.
I could remove the extra changes I made but, at least at the time, I couldn't then run the tests to ensure everything worked fine.
There was a problem hiding this comment.
I'm noticing the same error when testing the package using the source code, e.g. via :
pnpm pkg:test:src
Have you tried building the package first?
pnpm pkg:build
pnpm shortest
I'd rather address this issue in a separate PR, and keep this one only for fixing the Windows compatibility.
There was a problem hiding this comment.
Mmm, I don't think I did, but can't fully recall either. Either way you are right. No need to block this issue any further
…code readability" This reverts commit 29cfe0b.
rmarescu
changed the title
| @@ -21,7 +21,7 @@ | |||
| "dist/cli" | |||
| ], | |||
| "scripts": { | |||
| "build": "rm -rf dist && pnpm build:types && pnpm build:js && pnpm build:cli", | |||
| "build": "rimraf dist && pnpm build:types && pnpm build:js && pnpm build:cli", | |||
There was a problem hiding this comment.
rm -rf for Node in a cross-platform implementation
rmarescu
changed the title
Fixes #251
I also had to fix some issues with page.evaluate. Apparently __name is not defined due to how esbuild works, and was causing the tests to crash.
I have tested that the cli works when running pnpm build:pkg and than pnpm shortest --headless, on both windows and linux