Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spark SQL test "write null values" fails with Arrow error "Accounted size went negative" #1250

Open
andygrove opened this issue Jan 9, 2025 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@andygrove
Copy link
Member

andygrove commented Jan 9, 2025

Describe the bug

When we fix #1248 we find a new bug that causes the following Spark SQL test to fail:

- write null values *** FAILED *** (122 milliseconds)
2025-01-01T22:28:02.8649715Z Caused by: java.lang.IllegalArgumentException: Accounted size went negative.
2025-01-01T22:28:02.8650963Z 	at org.apache.comet.shaded.arrow.util.Preconditions.checkArgument(Preconditions.java:141)
2025-01-01T22:28:02.8652364Z 	at org.apache.comet.shaded.arrow.memory.Accountant.releaseBytes(Accountant.java:221)
2025-01-01T22:28:02.8653779Z 	at org.apache.comet.shaded.arrow.memory.RootAllocator.releaseBytes(RootAllocator.java:29)
2025-01-01T22:28:02.8655201Z 	at org.apache.comet.shaded.arrow.memory.AllocationManager.release(AllocationManager.java:154)
2025-01-01T22:28:02.8656578Z 	at org.apache.comet.shaded.arrow.memory.BufferLedger.decrement(BufferLedger.java:158)
2025-01-01T22:28:02.8658033Z 	at org.apache.comet.shaded.arrow.memory.BufferLedger.release(BufferLedger.java:125)
2025-01-01T22:28:02.8659503Z 	at org.apache.comet.shaded.arrow.memory.BufferLedger.release(BufferLedger.java:105)
2025-01-01T22:28:02.8660742Z 	at org.apache.comet.shaded.arrow.memory.ArrowBuf.close(ArrowBuf.java:1045)
2025-01-01T22:28:02.8661993Z 	at org.apache.comet.shaded.arrow.c.ArrowSchema.close(ArrowSchema.java:134)
2025-01-01T22:28:02.8663252Z 	at org.apache.comet.shaded.arrow.c.ArrowImporter.importField(ArrowImporter.java:47)
2025-01-01T22:28:02.8664510Z 	at org.apache.comet.shaded.arrow.c.ArrowImporter.importVector(ArrowImporter.java:53)
2025-01-01T22:28:02.8665809Z 	at org.apache.comet.vector.NativeUtil.$anonfun$importVector$1(NativeUtil.scala:191)
2025-01-01T22:28:02.8667257Z 	at org.apache.comet.vector.NativeUtil.$anonfun$importVector$1$adapted(NativeUtil.scala:184)
2025-01-01T22:28:02.8668467Z 	at scala.collection.immutable.Range.foreach(Range.scala:158)
2025-01-01T22:28:02.8669535Z 	at org.apache.comet.vector.NativeUtil.importVector(NativeUtil.scala:184)
2025-01-01T22:28:02.8670792Z 	at org.apache.comet.vector.NativeUtil.getNextBatch(NativeUtil.scala:164)
2025-01-01T22:28:02.8672117Z 	at org.apache.comet.CometExecIterator.getNextBatch(CometExecIterator.scala:92)
2025-01-01T22:28:02.8673399Z 	at org.apache.comet.CometExecIterator.hasNext(CometExecIterator.scala:105)

Steps to reproduce

See #1209

Expected behavior

No response

Additional context

No response

@andygrove andygrove added the bug Something isn't working label Jan 9, 2025
@andygrove andygrove added this to the 0.5.0 milestone Jan 9, 2025
@andygrove andygrove modified the milestones: 0.5.0, 0.6.0 Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant