fix: Fall back to Spark when hashing decimals with precision > 18 #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1325 +/- ##
=============================================
- Coverage 56.12% 34.31% -21.82%
- Complexity 976 1009 +33
=============================================
Files 119 125 +6
Lines 11743 48199 +36456
Branches 2251 10565 +8314
=============================================
+ Hits 6591 16538 +9947
- Misses 4012 28361 +24349
- Partials 1140 3300 +2160 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1294
Rationale for this change
Fix correctness issue
What changes are included in this PR?
Fall back to Spark when hashing decimals with precision > 18
How are these changes tested?