[Bug] ConcurrentBitmapSortedLongPairSet doesn't support pairs where the right value of the pair is larger than Integer.MAX_VALUE

[lhotari]

Search before asking

• I searched in the issues and found nothing similar.

Read release policy

• I understand that unsupported versions don't get bug fixes. I will attempt to reproduce the issue on a supported version of Pulsar client and Pulsar broker.

Version

any released version

Minimal reproduce step

ConcurrentBitmapSortedLongPairSet uses internally RoaringBitmap which supports values up to 2^32.
Since ConcurrentBitmapSortedLongPairSet uses Iterator<Integer> in the implementation, it can only support values up to 2^31-1 (Integer.MAX_INTEGER).

What did you expect to see?

Since the class interface and name is about supporting a Long pair, it should support long values for both right and left values of the pair.

What did you see instead?

Long value is not supported for the right value of the pair.

Anything else?

A possible solution would be to replace org.roaringbitmap.RoaringBitmap with org.roaringbitmap.longlong.Roaring64Bitmap.
However, Roaring64Bitmap interface is slightly different and would result in other changes.

An alternative mitigation is to improve ConcurrentBitmapSortedLongPairSet to support values up to 2^32. That is implemented in PR #23878.

Are you willing to submit a PR?

• I'm willing to submit a PR!

[lhotari]

#23878 has been merged and it supports values up to 2^32 (4294967296). This is 2 * (Integer.MAX_VALUE (2147483647) + 1) so there's an improvement that has been made..