-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: run prettier before eslint in pre-commit hooks (#31984)
- Loading branch information
1 parent
65c4d39
commit 925938b
Showing
1 changed file
with
8 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,14 +52,6 @@ repos: | |
- id: trailing-whitespace | ||
exclude: ^.*\.(snap) | ||
args: ["--markdown-linebreak-ext=md"] | ||
- repo: local | ||
hooks: | ||
- id: eslint | ||
name: eslint | ||
entry: bash -c 'cd superset-frontend && npm run eslint -- $(echo "$@" | sed "s|superset-frontend/||g")' | ||
language: system | ||
pass_filenames: true | ||
files: \.(js|jsx|ts|tsx)$ | ||
- repo: https://github.com/pre-commit/mirrors-prettier | ||
rev: v4.0.0-alpha.8 # Use the sha or tag you want to point at | ||
hooks: | ||
|
@@ -68,6 +60,14 @@ repos: | |
- [email protected] | ||
args: ["--ignore-path=./superset-frontend/.prettierignore"] | ||
files: "superset-frontend" | ||
- repo: local | ||
hooks: | ||
- id: eslint | ||
name: eslint | ||
entry: bash -c 'cd superset-frontend && npm run eslint -- $(echo "$@" | sed "s|superset-frontend/||g")' | ||
language: system | ||
pass_filenames: true | ||
files: \.(js|jsx|ts|tsx)$ | ||
# blacklist unsafe functions like make_url (see #19526) | ||
- repo: https://github.com/skorokithakis/blacklist-pre-commit-hook | ||
rev: e2f070289d8eddcaec0b580d3bde29437e7c8221 | ||
|