Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: Broken/Missing Icon for User Avatar After GitHub Login #1598

Open
2 tasks done
nikc129 opened this issue Jan 4, 2025 · 7 comments · May be fixed by #1606
Open
2 tasks done

🐛 Bug Report: Broken/Missing Icon for User Avatar After GitHub Login #1598

nikc129 opened this issue Jan 4, 2025 · 7 comments · May be fixed by #1606
Labels
bug Something isn't working

Comments

@nikc129
Copy link

nikc129 commented Jan 4, 2025

👟 Reproduction steps

1.Log in to Appwrite using the "Sign in with GitHub" option.
2.Observe the user avatar in the top-right corner and the "Invite" section.

Image

👍 Expected behavior

The user avatar should correctly display the GitHub profile picture or a default placeholder icon.

👎 Actual Behavior

A broken/missing icon is displayed instead of the expected user avatar.

🎲 Appwrite version

Version 1.6.x

💻 Operating system

Windows

🧱 Your Environment

No response

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

@nikc129 nikc129 added the bug Something isn't working label Jan 4, 2025
@cbum-dev
Copy link

cbum-dev commented Jan 4, 2025

I want to work on this issue. Please assign it to me.

@nikc129
Copy link
Author

nikc129 commented Jan 4, 2025

Hi @cbum-dev ,

Thanks for your interest in this issue! I don't have permissions to assign it, but I'm happy to support or provide additional details if needed. Looking forward to seeing your solution!

@stnguyen90 stnguyen90 transferred this issue from appwrite/appwrite Jan 5, 2025
@stnguyen90
Copy link
Contributor

@nikc129, thanks for creating this issue! 🙏🏼 Would you please check the network logs in the browser dev tools for a request to /v1/avatars/initials and share the URL? Also, do you have your name set in GitHub and Appwrite?

@cbum-dev
Copy link

cbum-dev commented Jan 5, 2025

Image
Hey @nikc129 and @stnguyen90 is this issue still their?

@nikc129
Copy link
Author

nikc129 commented Jan 5, 2025

Hi @stnguyen90 ,

Thanks for the follow-up and the suggestion! 🙏🏼 I double-checked, and it looks like the issue was resolved by setting the username in Appwrite. Apologies for the misunderstanding of the interface earlier!

That said, I’d like to propose a small feature enhancement:
In cases where the username or associated data isn’t set correctly, it might be helpful to display a default user icon (like a placeholder avatar). This would improve the UI and ensure a consistent user experience, even if there’s missing data.

Let me know what you think, and thanks again for looking into this! 😊

@cbum-dev
Copy link

cbum-dev commented Jan 5, 2025

Image
I would like to propose a change: in the light theme, the border of the avatar looks a bit off, and the text inside should be white to improve visibility.
Image
Something like this.

@nikc129
Copy link
Author

nikc129 commented Jan 5, 2025

Hi @cbum-dev ,

I completely agree that improving the avatar's border and text visibility in the light theme would enhance the UI. Making the text inside white is a great idea, as it would ensure better contrast and readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants