Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement flag parsing for Server. #4473

Open
4 tasks done
Tracked by #4453
ShohamBit opened this issue Jan 9, 2025 · 0 comments · May be fixed by #4469
Open
4 tasks done
Tracked by #4453

Implement flag parsing for Server. #4473

ShohamBit opened this issue Jan 9, 2025 · 0 comments · May be fixed by #4469

Comments

@ShohamBit
Copy link
Collaborator

ShohamBit commented Jan 9, 2025

Imapmaent the new design for the server flag as described:

Tasks

Preview Give feedback

The following design describes the CLI flag:

--server http.metrics=<true/false>        # Enable metrics endpoint
--server http.pprof=<true/false>          # Enable pprof endpoints
--server http.healthz=<true/false>       # Enable health check endpoint
--server http.pyroscope=<true/false>  # Enable Pyroscope agent
--server http.address=<address>        # Set HTTP server listening address
--server grpc.address=<address>       # Set gRPC server listening address

The following design describes the config:

server:
  http:
    metrics: false   # Enable metrics endpoint
    pprof: false     # Enable pprof endpoints
    healthz: false   # Enable health check endpoint
    pyroscope: false # Enable Pyroscope agent
    address: ":3366" # Set HTTP server listening address (default ":3366")
  grpc:
    address: ""      # Set gRPC server listening address (default: disabled)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant