Synced model with cast on creation not work

[galliroberto]

Bug description

Creation of synced model not work properly.
The cast field not works by design using getAttributes.
Use unsetRelations()->attributesToArray()

UpdateSyncedResource.php

        // We disable events for this call, to avoid triggering this event & listener again.
        $event->model->getCentralModelName()::withoutEvents(function () use (&$centralModel, $syncedAttributes, $event) {
            if ($centralModel) {
                $centralModel->update($syncedAttributes);
                event(new SyncedResourceChangedInForeignDatabase($event->model, null));
            } else {
                // If the resource doesn't exist at all in the central DB,we create
                // the record with all attributes, not just the synced ones.
                $centralModel = $event->model->getCentralModelName()::create($event->model->attributesToArray());
                event(new SyncedResourceChangedInForeignDatabase($event->model, null));
            }
        });

Before

After

Steps to reproduce

try to create a synced model with casted field like array

Expected behavior

During creation of synced mode, the casted field has to keep casted

Laravel version

11.35.1

stancl/tenancy version

3.8.5

[stancl]

Please include more clear examples for reproducing the behavior.

[galliroberto]

Laravel getAttributes doesn't cast the attribute, so it can't create a model with the right field.

My workflow is:
Inside a tenant I create a User.
Mu user has many casted fields, two of them are arrays.

In tenant the user has the right casted field, because laravel create it.

User is synced with CentralUser.

When I create a User, your package create a CentralUser and viceversa.

Using getAttributes, retrieve the field as text and not cast it to array.
When your package create CentralUser, use not casted field, in this case is a string of json and not array as the cast expected.

Let me know if I was clear now.

However, is the behaviour of getAttributes that make it happens.

[galliroberto]

To no lose hidden attribute

$event->model->makeVisible($event->model->getHidden()); // <------------------
$centralModel = $event->model->getCentralModelName()::create($event->model->attributesToArray());
event(new SyncedResourceChangedInForeignDatabase($event->model, null));

[stancl]

It's likely this was fixed in v4. I'll confirm that later.

We generally won't change resource syncing behavior in v3 even for small bugs since most fixes require significant breaking changes.

[galliroberto]

I have override the method.
I write also for others want to fix it.

For me was a big bug because broke my login.

When v4 will be released?