Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package not detecting Brave shields ad blocker #23

Open
rickstaa opened this issue Feb 16, 2023 · 6 comments
Open

Package not detecting Brave shields ad blocker #23

rickstaa opened this issue Feb 16, 2023 · 6 comments

Comments

@rickstaa
Copy link

Describe the bug

It seems that the package currently does not detect when ads are blocked using brave shields.

To Reproduce

Steps to reproduce the behaviour:

  1. Go to https://adblock-detect-react.vercel.app/ using a brave browser.
  2. Enable brave shields.
  3. See the ad blocker not being detected.

Expected behaviour

The brave shields adblocker should be detected.

Please complete the following information:

Additional context

I tried to find a way to detect when ad blocking is enabled in brave but could not yet find a way. There seems to be a bold object on the navigator, but it doesn't contain any shield information (see brave/brave-browser#10165 (comment)).

@rickstaa rickstaa changed the title Package not detecting shields add blocker Package not detecting shields ad blocker Feb 16, 2023
@rickstaa rickstaa changed the title Package not detecting shields ad blocker Package not detecting Brave shields ad blocker Feb 16, 2023
@ImLunaHey
Copy link

It looks like it's not working for any browsers I'm using. I get the same output no matter what with and without ad blocking running.

@ImLunaHey
Copy link

ImLunaHey commented Feb 18, 2023

Screen Shot 2023-02-18 at 7 14 12 pm

@rickstaa
Copy link
Author

Screen Shot 2023-02-18 at 7 14 12 pm

Thanks for the report. Which blocker are you using? It seems to work for Ublockplus on chrome:

image

@Wamy-Dev
Copy link

Wamy-Dev commented Mar 6, 2023

Also does not detect uBlock Origin using any browser

@DisabledMallis
Copy link

Don't fall for this 🙏

@Mohagames205
Copy link

I reported this to GitHub.

Hopefully the maintainer of this repo takes down the issue

Repository owner deleted a comment from mohamedSalehHegazy Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants