-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package not detecting Brave shields ad blocker #23
Comments
rickstaa
changed the title
Package not detecting shields add blocker
Package not detecting shields ad blocker
Feb 16, 2023
rickstaa
changed the title
Package not detecting shields ad blocker
Package not detecting Brave shields ad blocker
Feb 16, 2023
It looks like it's not working for any browsers I'm using. I get the same output no matter what with and without ad blocking running. |
Thanks for the report. Which blocker are you using? It seems to work for Ublockplus on chrome: |
Also does not detect uBlock Origin using any browser |
Don't fall for this 🙏 |
I reported this to GitHub. Hopefully the maintainer of this repo takes down the issue |
Repository owner
deleted a comment from
mohamedSalehHegazy
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
It seems that the package currently does not detect when ads are blocked using brave shields.
To Reproduce
Steps to reproduce the behaviour:
Expected behaviour
The brave shields adblocker should be detected.
Please complete the following information:
Additional context
I tried to find a way to detect when ad blocking is enabled in brave but could not yet find a way. There seems to be a bold object on the navigator, but it doesn't contain any shield information (see brave/brave-browser#10165 (comment)).
The text was updated successfully, but these errors were encountered: