Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create reusable input field. #31

Open
3 of 4 tasks
FarahZaqout opened this issue Oct 17, 2018 · 3 comments
Open
3 of 4 tasks

create reusable input field. #31

FarahZaqout opened this issue Oct 17, 2018 · 3 comments

Comments

@FarahZaqout
Copy link
Collaborator

FarahZaqout commented Oct 17, 2018

Input field component:

The component should be usable across the website. For that, it needs to take different types, different classes, and different placeholders, values and names.

Acceptance criteria:

  • sufficiently tested.
  • props are validated.
  • props include type, class, placeholder, value, and name.
  • component should be stateless function.

relates #32

@FarahZaqout
Copy link
Collaborator Author

FarahZaqout commented Oct 19, 2018

day1: finalized all the required input props with validation

Stopped working yesterday and today to fix urgent issues with Travis, along with @amusameh and @ashatat.

What remains is to make sure it's well tested. Will resume working on it later today (jest tests).

@FarahZaqout
Copy link
Collaborator Author

Component should be ready for review by the end of tomorrow at most.

@FarahZaqout
Copy link
Collaborator Author

Must read jest and use it on another independent repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant