Move from custom component to external component #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SibrenVasse
force-pushed
the
PR
branch
5 times, most recently
from
9c18ae3 to
5b8735a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom components are deprecated in ESPHome and will be removed in future versions.
https://esphome.io/custom/custom_component.html
This PR rewrites this project to use an external component. The project can be used in a yaml file using a git URL in the
external_componentssection. The remote source in the example file doesn't work at the moment, because this PR is not merged yet. This means that for testing the local source should be used.I've been running this on my inverter, a FoxESS F3000 for some time now without issues.
Please let me know if any changes are required to get this in a mergeable state.
Fixes #21