Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruff fails on the issue introduced during fix #5150

Open
Cjkjvfnby opened this issue Jun 16, 2023 · 0 comments · May be fixed by #15706
Open

Ruff fails on the issue introduced during fix #5150

Cjkjvfnby opened this issue Jun 16, 2023 · 0 comments · May be fixed by #15706
Labels
fixes Related to suggested fixes for violations

Comments

@Cjkjvfnby
Copy link
Contributor

Applying FLY002 to the code creates a code that does not pass E501 Line too long

This check is mentioned in the #2102

Code sample:

expected = "\n".join(
    [
        "=== long text ======================================================================",
        "=== long text ======================================================================",
    ],
)
ruff scratch.py
scratch.py:1:12: FLY002 [*] Consider `"=== long text ======================================================================\n=== long text ======================================================================"` instead of string join    
Found 1 errors.
[*] 1 potentially fixable with the --fix option.
ruff scratch.py --fix
scratch.py:1:99: E501 Line too long (183 > 98 characters)
Found 1 errors (1 fixed, 0 remaining).
@charliermarsh charliermarsh added the fixes Related to suggested fixes for violations label Jun 17, 2023
@InSyncWithFoo InSyncWithFoo linked a pull request Jan 24, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixes Related to suggested fixes for violations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[flynt] Do not offer a fix when the new string is too long (FLY002) InSyncWithFoo/ruff
2 participants
@Cjkjvfnby @charliermarsh