Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objective 01a: use v5/6/7 #187

Closed
atoomic opened this issue Aug 10, 2020 · 8 comments
Closed

Objective 01a: use v5/6/7 #187

atoomic opened this issue Aug 10, 2020 · 8 comments
Assignees
Labels
objective mileposts for 'alpha' development

Comments

@atoomic
Copy link
Owner

atoomic commented Aug 10, 2020

Objective:

  • restore use 5.x behavior
  • block use >= 5.33
  • block use 6 or use v6
  • introduce a new behavior for use v7

View prototype from c1eb819

view discussion from: #153 (comment)

Acceptance Criteria: clean test suite

@atoomic atoomic added the objective mileposts for 'alpha' development label Aug 10, 2020
@atoomic atoomic self-assigned this Aug 10, 2020
@jkeenan
Copy link
Collaborator

jkeenan commented Aug 10, 2020

Objective:

* restore use 5.x behavior

@atoomic , can you elaborate on what is meant by "5.x behavior" here? That is, what is the current behavior (as of the completion of Objective 1) and what are we restoring it to?

* block `use > 5.32.1`

But what if we do a second maintenance release for 5.32, i.e., perl-5.32.2?

* block use 6 or use v6

* introduce a new behavior for use v7

What is the new behavior you wish to introduce for use v7;?

View prototype from c1eb819

view discussion from: #153 (comment)

Acceptance Criteria: clean test suite

@jkeenan
Copy link
Collaborator

jkeenan commented Aug 10, 2020

Some test files on which this work may have an impact:

t/porting/diag.t
t/comp/use.t
t/run/switches.t

As well as others touched in c1eb819

@jkeenan
Copy link
Collaborator

jkeenan commented Aug 11, 2020

Objective:

* restore use 5.x behavior

@atoomic , can you elaborate on what is meant by "5.x behavior" here? That is, what is the current behavior (as of the completion of Objective 1) and what are we restoring it to?

* block `use > 5.32.1`

But what if we do a second maintenance release for 5.32, i.e., perl-5.32.2?

* block use 6 or use v6

* introduce a new behavior for use v7

What is the new behavior you wish to introduce for use v7;?

View prototype from c1eb819
view discussion from: #153 (comment)
Acceptance Criteria: clean test suite

Getting these questions clarified will be important in resolving questions discussed in PSC Technical meeting this morning.

Thanks.
jimk

@atoomic
Copy link
Owner Author

atoomic commented Aug 11, 2020

I agree we need clarification on the direction to take.

Here are the answers to your questions:

  1. restore 5.x behavior: use 5.5 which stands for use v5.500 should also fail in Perl 7
    without any change it's not failing, as 5.500 < 7.000, but use 5.5 is a mistake for someone probably meaning use v5.5

  2. in fact we should block use >= 5.33, if 5.34 is released then this should change to >= 5.35
    -1- and -2- are linked each other as this is giving us the boundary to check when we see 5.*

  3. use v7: do we want keep using use v7.x.y and have multiple flavors of Perl 7...
    or would we prefer using use v7 and if needed use experimental :8

@jkeenan
Copy link
Collaborator

jkeenan commented Aug 11, 2020

I agree we need clarification on the direction to take.

Here are the answers to your questions:

1. restore 5.x behavior: `use 5.5` which stands for `use v5.500` should also fail in Perl 7
   without any change it's not failing, as `5.500 < 7.000`, but `use 5.5` is a mistake for someone probably meaning `use v5.5`

2. in fact we should block `use >= 5.33`, if 5.34 is released then this should change to `>= 5.35`
   -1- and -2- are linked each other as this is giving us the boundary to check when we see 5.*

3. `use v7`: do we want keep using `use v7.x.y` and have multiple flavors of Perl 7...
   or would we prefer using `use v7` and if needed `use experimental :8`

Thanks for getting back to me on this. Do you have an estimated timeline for completion of this mini-objective?

jimk

@atoomic
Copy link
Owner Author

atoomic commented Aug 11, 2020

@jkeenan I can work on something for this objective 01a in a matter of a few hours,
but I really wonder if it worth the effort before we know where we are going... and I'm afraid that this is going to take weeks...

Let me see if I can come with something clean and isolated to reach what I've in mind.
We can still massage it later.

@atoomic
Copy link
Owner Author

atoomic commented Aug 11, 2020

@jkeenan #189 provides the basic implementation for this case

@jkeenan
Copy link
Collaborator

jkeenan commented Aug 12, 2020

Achieved via #189. I have added a tag.

commit 9420ed5e3260fb4fcef4b50c795ac0b0b413ddb9 (HEAD -> alpha, tag: alpha-01a, upstream/alpha)
Merge: 02980c45c5 a1869a70e6
Author:     Nicolas R <[email protected]>
AuthorDate: Wed Aug 12 16:12:34 2020 -0600
Commit:     GitHub <[email protected]>
CommitDate: Wed Aug 12 16:12:34 2020 -0600

@jkeenan jkeenan closed this as completed Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
objective mileposts for 'alpha' development
Projects
None yet
Development

No branches or pull requests

2 participants